don't crash when select / extend_select are None (#261)

Author: asottile

bugbear.py

@@ -155,12 +155,13 @@ def should_warn(self, code):
             return True
 
         for i in range(2, len(code) + 1):
-            if code[:i] in self.options.select:
+            if self.options.select and code[:i] in self.options.select:
                 return True
 
             # flake8 >=4.0: Also check for codes in extend_select
             if (
                 hasattr(self.options, "extend_select")
+                and self.options.extend_select
                 and code[:i] in self.options.extend_select
             ):
                 return True

tests/test_bugbear.py

@@ -438,6 +438,16 @@ def test_b9_extend_select(self):
             ),
         )
 
+    def test_b9_flake8_next_default_options(self):
+        filename = Path(__file__).absolute().parent / "b950.py"
+
+        # in flake8 next, unset select / extend_select will be `None` to
+        # signify the default values
+        mock_options = Namespace(select=None, extend_select=None)
+        bbc = BugBearChecker(filename=str(filename), options=mock_options)
+        errors = list(bbc.run())
+        self.assertEqual(errors, [])
+
     def test_selfclean_bugbear(self):
         filename = Path(__file__).absolute().parent.parent / "bugbear.py"
         proc = subprocess.run(