Skip to content

Commit 1a3f827

Browse files
authored
Merge pull request #850 from asottile/E721_false_positive
Fix E721 false positive
2 parents d1e2986 + 0327e55 commit 1a3f827

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

pycodestyle.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def lru_cache(maxsize=128): # noqa as it's a fake implementation.
139139
COMPARE_SINGLETON_REGEX = re.compile(r'(\bNone|\bFalse|\bTrue)?\s*([=!]=)'
140140
r'\s*(?(1)|(None|False|True))\b')
141141
COMPARE_NEGATIVE_REGEX = re.compile(r'\b(not)\s+[^][)(}{ ]+\s+(in|is)\s')
142-
COMPARE_TYPE_REGEX = re.compile(r'(?:[=!]=|is(?:\s+not)?)\s*type(?:s.\w+Type'
142+
COMPARE_TYPE_REGEX = re.compile(r'(?:[=!]=|is(?:\s+not)?)\s+type(?:s.\w+Type'
143143
r'|\s*\(\s*([^)]*[^ )])\s*\))')
144144
KEYWORD_REGEX = re.compile(r'(\s*)\b(?:%s)\b(\s*)' % r'|'.join(KEYWORDS))
145145
OPERATOR_REGEX = re.compile(r'(?:[^,\s])(\s*)(?:[-+*/|!<=>%&^]+)(\s*)')

testsuite/E72.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,9 @@
4949
pass
5050
if type(a) != type(b) or type(a) == type(ccc):
5151
pass
52+
#: Okay
53+
def func_histype(a, b, c):
54+
pass
5255
#: E722
5356
try:
5457
pass

0 commit comments

Comments
 (0)