Added test for importing __all__

Author: Nurdok

src/pydocstyle.py

@@ -507,16 +507,28 @@ def parse_from_import_statement(self):
 
         """
         log.debug('parsing from/import statement.')
+        is_future_import = self._parse_from_import_source()
+        self._parse_from_import_names(is_future_import)
+
+    def _parse_from_import_source(self):
+        """Parse the 'from x import' part in a 'from x import y' statement.
+
+        Return true iff `x` is __future__.
+        """
         assert self.current.value == 'from', self.current.value
         self.stream.move()
         is_future_import = self.current.value == '__future__'
         self.stream.move()
         while (self.current.kind in (tk.DOT, tk.NAME, tk.OP) and
-               self.current.value != 'import'):
+                       self.current.value != 'import'):
             self.stream.move()
         self.check_current(value='import')
         assert self.current.value == 'import', self.current.value
         self.stream.move()
+        return is_future_import
+
+    def _parse_from_import_names(self, is_future_import):
+        """Parse the 'y' part in a 'from x import y' statement."""
         if self.current.value == '(':
             self.consume(tk.OP)
             expected_end_kind = tk.OP

src/tests/test_cases/all_import.py

@@ -1,18 +1,17 @@
 """A valid module docstring."""
 
-from .all_import_aux import __all__ as not_dunder_all
+from .all_import_aux import __all__
 from .expected import Expectation
 
 expectation = Expectation()
 expect = expectation.expect
 
-__all__ = ('public_func', )
-
 
 @expect("D103: Missing docstring in public function")
 def public_func():
     pass
 
 
-def private_func():
+@expect("D103: Missing docstring in public function")
+def this():
     pass

src/tests/test_cases/all_import_as.py

@@ -0,0 +1,18 @@
+"""A valid module docstring."""
+
+from .all_import_aux import __all__ as not_dunder_all
+from .expected import Expectation
+
+expectation = Expectation()
+expect = expectation.expect
+
+__all__ = ('public_func', )
+
+
+@expect("D103: Missing docstring in public function")
+def public_func():
+    pass
+
+
+def private_func():
+    pass

src/tests/test_definitions.py

@@ -261,6 +261,7 @@ def test_token_stream():
     'comment_after_def_bug',
     'multi_line_summary_start',
     'all_import',
+    'all_import_as',
 ])
 def test_pep257(test_case):
     """Run domain-specific tests from test.py file."""