Incorporated superfluous quote checking to D300.

Author: Nurdok

docs/release_notes.rst

@@ -10,15 +10,16 @@ Current Development Version
 Major Updates
 
 * Support for Python 2.6 has been dropped (#206, #217).
-* Support for PyPy3 2.6 has been temporarily dropped, until it will be
-  equivalent to CPython 3.3+ (#223).
+* Support for PyPy3 has been temporarily dropped, until it will be
+  equivalent to CPython 3.3+ and supported by ``pip`` (#223).
 * Support for the ``pep257`` console script has been dropped. Only the
   ``pydocstyle`` console script should be used (#216, #218).
 
 New Features
 
 * Decorator-based skipping via ``--ignore-decorators`` has been added (#204).
 * Support for using pycodestyle style wildcards has been added (#72, #209).
+* Superfluous opening quotes are now reported as part of D300 (#166, #224).
 
 Bug Fixes
 
@@ -27,6 +28,7 @@ Bug Fixes
   underscore. This is a bugfix where "public module" (D100) was reported
   regardless of module name (#199, #222).
 
+
 1.1.1 - October 4th, 2016
 -------------------------
 

docs/snippets/publicity.rst

@@ -4,7 +4,7 @@ determined and what its effects are.
 
 
 How publicity is determined
-===========================
+^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 Publicity for all constructs is determined as follows: a construct is
 considered *public* if -
@@ -27,7 +27,7 @@ name does not begin with a single underscore.
 
 
 How publicity affects error reports
-===================================
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 The immediate effect of a construct being determined as private is that no
 D1xx errors will be reported for it (or its children, as the previous section

src/pydocstyle/checker.py

@@ -275,16 +275,17 @@ def check_triple_double_quotes(self, definition, docstring):
 
         '''
         if docstring:
-            opening = docstring[:5].lower()
-            if '"""' in ast.literal_eval(docstring) and opening.startswith(
-                    ("'''", "r'''", "u'''", "ur'''")):
+            if '"""' in ast.literal_eval(docstring):
                 # Allow ''' quotes if docstring contains """, because
                 # otherwise """ quotes could not be expressed inside
                 # docstring. Not in PEP 257.
-                return
-            if not opening.startswith(('"""', 'r"""', 'u"""', 'ur"""')):
-                quotes = "'''" if "'''" in opening else "'"
-                return violations.D300(quotes)
+                regex = re(r"[uU]?[rR]?'''[^'].*")
+            else:
+                regex = re(r'[uU]?[rR]?"""[^"].*')
+
+            illegal_matcher = re(r"""[uU]?[rR]?("+|'+).*""")
+            if not regex.match(docstring):
+                return violations.D300(illegal_matcher.match(docstring).group(1))
 
     @check_for(Definition)
     def check_backslashes(self, definition, docstring):

src/tests/test_cases/superfluous_quotes.py

@@ -0,0 +1,21 @@
+"""A valid module docstring."""
+
+from .expected import Expectation
+
+expectation = Expectation()
+expect = expectation.expect
+
+
+def correct_func():
+    """Three quotes in both sides."""
+
+
+@expect('D300: Use """triple double quotes""" (found """"-quotes)')
+def extra_opening():
+    """"Extra quote on the left."""
+
+
+@expect('D300: Use """triple double quotes""" (found """""-quotes)')
+def two_extra_opening():
+    """""Two extra quotes on the left."""
+

src/tests/test_definitions.py

@@ -276,6 +276,7 @@ def test_token_stream():
     'multi_line_summary_start',
     'all_import',
     'all_import_as',
+    'superfluous_quotes',
 ])
 def test_pep257(test_case):
     """Run domain-specific tests from test.py file."""