Drop support for Python 3.4 and remove unsupported Python versions leftovers (#402)

* Remove PyPy leftovers

PyPy support was removed in version 4.0.0.

* Remove Python 2 leftovers

Python 2.7 support was removed in version 4.0.0, and older Python 2
versions long before that.

* Drop support for Python 3.4

Python 3.4 has reached end-of-life and has been retired in Mar 2019:
https://www.python.org/dev/peps/pep-0429/.

* Drop requirements on packages providing backports for older Pythons

Author: tjanez

.appveyor.yml

@@ -1,10 +1,8 @@
 environment:
   matrix:
-    - TOXENV: "py34-tests"
     - TOXENV: "py35-tests"
     - TOXENV: "py36-tests"
     - TOXENV: "py37-tests"
-    - TOXENV: "py34-install"
     - TOXENV: "py35-install"
     - TOXENV: "py36-install"
     - TOXENV: "py37-install"

.travis.yml

@@ -9,8 +9,6 @@ install: pip install tox
 script: tox
 matrix:
   include:
-    - python: 3.4
-      env: TOXENV=py34-tests
     - python: 3.5
       env: TOXENV=py35-tests
     - python: 3.6
@@ -19,8 +17,6 @@ matrix:
       dist: xenial
       sudo: required
       env: TOXENV=py37-tests
-    - python: 3.4
-      env: TOXENV=py34-install
     - python: 3.5
       env: TOXENV=py35-install
     - python: 3.6

README.rst

@@ -23,7 +23,7 @@ docstring conventions.
 `PEP 257 <http://www.python.org/dev/peps/pep-0257/>`_ out of the box, but it
 should not be considered a reference implementation.
 
-**pydocstyle** supports Python 3.4, 3.5, 3.6 and 3.7.
+**pydocstyle** supports Python 3.5, 3.6 and 3.7.
 
 
 Quick Start

docs/index.rst

@@ -8,7 +8,7 @@ docstring conventions.
 `PEP 257 <http://www.python.org/dev/peps/pep-0257/>`_ out of the box, but it
 should not be considered a reference implementation.
 
-**pydocstyle** supports Python 3.4, 3.5, 3.6, 3.7, and pypy.
+**pydocstyle** supports Python 3.5, 3.6, and 3.7.
 
 
 .. include:: quickstart.rst

docs/release_notes.rst

@@ -7,6 +7,10 @@ Release Notes
 Current Development Version
 ---------------------------
 
+Major Updates
+
+* Support for Python 3.4 has been dropped (#402).
+
 New Features
 
 * Extend support for detecting missing arguments in Google style

requirements/runtime.txt

@@ -1,2 +1 @@
 snowballstemmer==1.2.1
-configparser==3.5.0

requirements/tests.txt

@@ -1,7 +1,3 @@
 pytest==3.0.2
 pytest-pep8==1.0.6
-mock==2.0.0
-pathlib
 mypy==0.630
-six
-typing

setup.py

@@ -1,4 +1,3 @@
-from __future__ import with_statement
 from setuptools import setup
 import sys
 
@@ -25,14 +24,13 @@
         'Environment :: Console',
         'Development Status :: 5 - Production/Stable',
         'Programming Language :: Python :: 3',
-        'Programming Language :: Python :: 3.4',
         'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
         'Operating System :: OS Independent',
         'License :: OSI Approved :: MIT License',
     ],
-    python_requires='>=3.4',
+    python_requires='>=3.5',
     keywords='pydocstyle, PEP 257, pep257, PEP 8, pep8, docstrings',
     packages=('pydocstyle',),
     package_dir={'': 'src'},

src/pydocstyle/config.py

@@ -4,18 +4,13 @@
 import itertools
 import os
 from collections import namedtuple
+from collections.abc import Set
 from re import compile as re
 from configparser import RawConfigParser
 
 from .utils import __version__, log
 from .violations import ErrorRegistry, conventions
 
-try:
-    from collections.abc import Set
-except ImportError:
-    # python 2.7
-    from collections import Set
-
 
 def check_initialized(method):
     """Check that the configuration object was initialized."""

src/tests/parser_test.py

@@ -1,7 +1,6 @@
 """Parser tests."""
 
 import io
-import six
 import sys
 import pytest
 import textwrap
@@ -434,8 +433,6 @@ def test_raise_from():
 
 def test_simple_matrix_multiplication():
     """Make sure 'a @ b' doesn't trip the parser."""
-    if sys.version_info.minor < 5:
-        return
     parser = Parser()
     code = CodeSnippet("""
         def foo():
@@ -446,8 +443,6 @@ def foo():
 
 def test_matrix_multiplication_with_decorators():
     """Make sure 'a @ b' doesn't trip the parser."""
-    if sys.version_info.minor < 5:
-        return
     parser = Parser()
     code = CodeSnippet("""
         def foo():
@@ -608,13 +603,10 @@ def test_single_value_dunder_all():
         foo = 'foo'
         __all__ = [foo]
     """),
+    CodeSnippet("""\
+        __all__ = (*foo, 'bar')
+    """),
 ]
-if six.PY3 and not six.PY34:
-    indeterminable_dunder_all_test_cases += [
-        CodeSnippet("""\
-                __all__ = (*foo, 'bar')
-            """),
-    ]
 
 
 @pytest.mark.parametrize("code", indeterminable_dunder_all_test_cases)
@@ -655,16 +647,6 @@ def test_indeterminable_dunder_all(code):
         from __future__ \\
         import nested_scopes
     """),
-
-    # The following code snippet fails for PyPy, see:
-    # "Future statements are considered illegal if they are separated
-    # by a semicolon"
-    # https://bitbucket.org/pypy/pypy/issues/2526/
-
-    # CodeSnippet("""\
-    #     from __future__ import unicode_literals; from __future__ import \
-    #     nested_scopes
-    # """),
 ))
 def test_future_import(code):
     """Test that __future__ imports are properly parsed and collected."""