Fix crashes when using fixture + if + inline import

Author: reverbc

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## [Unreleased]
 ### Fixed
 - Fix fixtures defined with `@pytest.yield_fixture` decorator still showing FP
+- Fix crashes when using fixture + if + inline import
 
 ## [0.1.1] - 2020-05-19
 ### Fixed

pylint_pytest.py

@@ -193,12 +193,14 @@ def patched_add_message(self, msgid, line=None, node=None, args=None,
         # check W0613 unused-argument
         if msgid == 'unused-argument' and \
                 _can_use_fixture(node.parent.parent) and \
+                isinstance(node.parent, astroid.Arguments) and \
                 node.name in self._pytest_fixtures:
             return
 
         # check W0621 redefined-outer-name
         if msgid == 'redefined-outer-name' and \
                 _can_use_fixture(node.parent.parent) and \
+                isinstance(node.parent, astroid.Arguments) and \
                 node.name in self._pytest_fixtures:
             return
 

tests/base_tester.py

@@ -24,7 +24,7 @@ def _verify(self, module, msg_count, msg_id=None):
 
         assert matched_count == msg_count
 
-    def run_test(self, msg_count, enable_plugin):
+    def run_test(self, msg_count, enable_plugin, msg_id=None):
         # pylint: disable=protected-access
         file = sys._getframe(1).f_code.co_name.replace('test_', '', 1) + '.py'
         full_file_path = os.path.join(
@@ -41,6 +41,7 @@ def run_test(self, msg_count, enable_plugin):
                 self._verify(
                     module=module,
                     msg_count=msg_count,
+                    msg_id=msg_id,
                 )
             finally:
                 if enable_plugin:

tests/input/regression/import_twice.py

@@ -0,0 +1,6 @@
+from conftest import conftest_fixture_func
+
+
+def test_using_conftest_fixture_attr():
+    if True:
+        from conftest import conftest_fixture_func

tests/test_regression.py

@@ -0,0 +1,22 @@
+import pytest
+from base_tester import BasePytestFixtureChecker
+
+
+class TestRegression(BasePytestFixtureChecker):
+    '''Covering some behaviors that shouldn't get impacted by the plugin'''
+    MSG_ID = 'regression'
+
+    @pytest.mark.parametrize('enable_plugin', [True, False])
+    def test_import_twice(self, enable_plugin):
+        '''catch a coding error when using fixture + if + inline import'''
+        self.run_test(
+            enable_plugin=enable_plugin,
+            msg_count=2,
+            msg_id='unused-import'
+        )
+
+        self.run_test(
+            enable_plugin=enable_plugin,
+            msg_count=1,
+            msg_id='redefined-outer-name'
+        )