fix crash on args/kwargs

Author: reverbc

pylint_pytest.py

@@ -191,14 +191,14 @@ def patched_add_message(self, msgid, line=None, node=None, args=None,
 
         # check W0613 unused-argument
         if msgid == 'unused-argument' and \
-                node.name in self._pytest_fixtures and \
-                _can_use_fixture(node.parent.parent):
+                _can_use_fixture(node.parent.parent) and \
+                node.name in self._pytest_fixtures:
             return
 
         # check W0621 redefined-outer-name
         if msgid == 'redefined-outer-name' and \
-                node.name in self._pytest_fixtures and \
-                _can_use_fixture(node.parent.parent):
+                _can_use_fixture(node.parent.parent) and \
+                node.name in self._pytest_fixtures:
             return
 
         if int(pylint.__version__.split('.')[0]) >= 2:

tests/input/redefined-outer-name/args_and_kwargs.py

@@ -0,0 +1,11 @@
+def args():
+    pass
+
+
+def kwargs():
+    pass
+
+
+def not_a_test_function(*args, **kwargs):
+    # invalid test case...
+    assert True

tests/input/unused-argument/args_and_kwargs.py

@@ -0,0 +1,3 @@
+def not_a_test_function(*args, **kwargs):
+    # invalid test case...
+    assert True

tests/test_redefined_outer_name.py

@@ -18,3 +18,10 @@ def test_caller_not_a_test_func(self, enable_plugin):
             enable_plugin=enable_plugin,
             msg_count=1,
         )
+
+    @pytest.mark.parametrize('enable_plugin', [True, False])
+    def test_args_and_kwargs(self, enable_plugin):
+        self.run_test(
+            enable_plugin=enable_plugin,
+            msg_count=2,
+        )

tests/test_unused_argument.py

@@ -18,3 +18,10 @@ def test_caller_not_a_test_func(self, enable_plugin):
             enable_plugin=enable_plugin,
             msg_count=1,
         )
+
+    @pytest.mark.parametrize('enable_plugin', [True, False])
+    def test_args_and_kwargs(self, enable_plugin):
+        self.run_test(
+            enable_plugin=enable_plugin,
+            msg_count=2,
+        )