Use platformdirs instead of appdirs (#489)

* Use platformdirs instead of appdirs

Use the better maintained `platformdirs` instead of `appdirs`.

* Add @felixonmars to the list of contributors

* Update `CHANGELOG.md` with changes from #489

Co-authored-by: Martin Larralde <[email protected]>

Author: felixonmars

CHANGELOG.md

@@ -8,6 +8,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Unreleased
 
+### Changed
+
+- Replaced `appdirs` with `platformdirs` dependency 
+  ([#489](https://github.com/PyFilesystem/pyfilesystem2/pull/489)).
+
 
 ## [2.4.15] - 2022-02-07
 

CONTRIBUTORS.md

@@ -14,6 +14,7 @@ Many thanks to the following developers for contributing to this project:
 - [Diego Argueta](https://github.com/dargueta)
 - [Eelke van den Bos](https://github.com/eelkevdbos)
 - [Egor Namakonov](https://github.com/fresheed)
+- [Felix Yan](https://github.com/felixonmars)
 - [@FooBarQuaxx](https://github.com/FooBarQuaxx)
 - [Geoff Jukes](https://github.com/geoffjukes)
 - [George Macon](https://github.com/gmacon)

fs/appfs.py

@@ -5,7 +5,7 @@
 subclasses of `~fs.osfs.OSFS`.
 
 """
-# Thanks to authors of https://pypi.org/project/appdirs
+# Thanks to authors of https://pypi.org/project/platformdirs
 
 # see http://technet.microsoft.com/en-us/library/cc766489(WS.10).aspx
 
@@ -16,7 +16,7 @@
 
 from .osfs import OSFS
 from ._repr import make_repr
-from appdirs import AppDirs
+from platformdirs import PlatformDirs
 
 if typing.TYPE_CHECKING:
     from typing import Optional, Text
@@ -78,7 +78,7 @@ def __init__(
                 will be created if it does not exist.
 
         """
-        self.app_dirs = AppDirs(appname, author, version, roaming)
+        self.app_dirs = PlatformDirs(appname, author, version, roaming)
         self._create = create
         super(_AppFS, self).__init__(
             getattr(self.app_dirs, self.app_dir), create=create

setup.cfg

@@ -42,7 +42,7 @@ packages = find:
 setup_requires =
     setuptools >=38.3.0
 install_requires =
-    appdirs~=1.4.3
+    platformdirs~=2.0.2
     setuptools
     six ~=1.10
     enum34 ~=1.1.6      ;  python_version < '3.4'

tests/test_appfs.py

@@ -30,7 +30,7 @@ def tearDownClass(cls):
 
     def make_fs(self):
         with mock.patch(
-            "appdirs.{}".format(self.AppFS.app_dir),
+            "platformdirs.{}".format(self.AppFS.app_dir),
             autospec=True,
             spec_set=True,
             return_value=tempfile.mkdtemp(dir=self.tmpdir),

tests/test_opener.py

@@ -264,7 +264,7 @@ def test_open_fs(self):
         mem_fs_2 = opener.open_fs(mem_fs)
         self.assertEqual(mem_fs, mem_fs_2)
 
-    @mock.patch("appdirs.{}".format(UserDataFS.app_dir), autospec=True, spec_set=True)
+    @mock.patch("platformdirs.{}".format(UserDataFS.app_dir), autospec=True, spec_set=True)
     def test_open_userdata(self, app_dir):
         app_dir.return_value = self.tmpdir
 
@@ -276,7 +276,7 @@ def test_open_userdata(self, app_dir):
         self.assertEqual(app_fs.app_dirs.appauthor, "willmcgugan")
         self.assertEqual(app_fs.app_dirs.version, "1.0")
 
-    @mock.patch("appdirs.{}".format(UserDataFS.app_dir), autospec=True, spec_set=True)
+    @mock.patch("platformdirs.{}".format(UserDataFS.app_dir), autospec=True, spec_set=True)
     def test_open_userdata_no_version(self, app_dir):
         app_dir.return_value = self.tmpdir
 
@@ -285,7 +285,7 @@ def test_open_userdata_no_version(self, app_dir):
         self.assertEqual(app_fs.app_dirs.appauthor, "willmcgugan")
         self.assertEqual(app_fs.app_dirs.version, None)
 
-    @mock.patch("appdirs.{}".format(UserDataFS.app_dir), autospec=True, spec_set=True)
+    @mock.patch("platformdirs.{}".format(UserDataFS.app_dir), autospec=True, spec_set=True)
     def test_user_data_opener(self, app_dir):
         app_dir.return_value = self.tmpdir