FSTestCases.test_setinfo is broken

[atollk]

I haven't quite grasped the whole concepts of how the "info" namespaces work but just letting the tests run, I found this piece:

pyfilesystem2/fs/test.py

Line 1179 in f6a6195

if "accessed" in new_info.get("_write", []):

new_info actually never contains "_write" as a key for any test case that is called atm, so this test is pretty much a noop.

[althonos]

Nice catch. Actually, the _write key is used here and there to mark which keys within an info namespace are writable, so the right code should be:

if "accessed" in new_info.get("details", {}).get("_write", []):
    ...

I tried to document this feature in the latest release in the Info.is_writeable method. I don't think it's really enforced otherwise.

[lurch]

I couldn't figure out what it meant for an "info key to be writeable" and tracked down the commit where it was added 37fd107

Still took me a while to figure out what it meant, but I think I eventually realised that it means that the key can be modified with a call to .setinfo? Perhaps it's worth updating the is_writeable docstring to include something like "...that lists which keys are writable on the underlying resource by a call to setinfo()" ? 🤷‍♂️

[lurch]

This is fixed by #479 ?

[atollk]

@lurch I think so. I changed the test to use is_writable (link) and added a sentence of documentation (link).

Although I didn't check whether there are any other tests that are hurt by the same problem. But imo, this can be closed.