Skip to content

Commit 507382f

Browse files
committed
Some methods have been hidden.
1 parent 9b4f207 commit 507382f

File tree

5 files changed

+59
-50
lines changed

5 files changed

+59
-50
lines changed

veriloggen/core/function.py

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,22 @@ def Body(self, *statement):
4444
def call(self, *args):
4545
return FunctionCall(self, *args)
4646

47-
def next(self, r):
48-
return self.__call__(r)
47+
def next(self, value):
48+
return vtypes.Subst(self, value)
4949

50-
def add_subst(self, s):
50+
def bit_length(self):
51+
return self.width
52+
53+
def write(self, value):
54+
return self.next(value)
55+
56+
def _add_subst(self, s):
5157
self.subst.append(s)
5258

53-
def set_raw_width(self, msb, lsb):
59+
def _get_subst(self):
60+
return self.subst
61+
62+
def _set_raw_width(self, msb, lsb):
5463
self.width_msb = msb
5564
self.width_lsb = lsb
5665

@@ -61,8 +70,8 @@ def __setattr__(self, attr, value):
6170
object.__setattr__(self, 'width_lsb', None)
6271
object.__setattr__(self, attr, value)
6372

64-
def __call__(self, r):
65-
return vtypes.Subst(self, r)
73+
def __call__(self, value):
74+
return self.next(value)
6675

6776
class FunctionCall(vtypes._Numeric):
6877
def __init__(self, func, *args):

veriloggen/core/vtypes.py

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -270,29 +270,29 @@ def __init__(self, width=1, length=None, signed=False, value=None, initval=None,
270270
self.initval = initval
271271
self.subst = []
272272

273-
def next(self, r, ldelay=None, rdelay=None):
274-
return Subst(self, r, ldelay=ldelay, rdelay=rdelay)
275-
276-
def connect(self, prefix='', postfix=''):
277-
return ( prefix + self.name + postfix, self )
278-
279-
def add_subst(self, s):
280-
self.subst.append(s)
273+
def next(self, value, blk=False, ldelay=None, rdelay=None):
274+
return Subst(self, value, blk=blk, ldelay=ldelay, rdelay=rdelay)
281275

282-
def get_subst(self):
283-
return self.subst
276+
def write(self, value, blk=False, ldelay=None, rdelay=None):
277+
return self.next(value, blk=blk, ldelay=ldelay, rdelay=rdelay)
284278

285279
def reset(self):
286280
return None
287281

288282
def bit_length(self):
289283
return self.width
290284

291-
def set_raw_width(self, msb, lsb):
285+
def _add_subst(self, s):
286+
self.subst.append(s)
287+
288+
def _get_subst(self):
289+
return self.subst
290+
291+
def _set_raw_width(self, msb, lsb):
292292
self.width_msb = msb
293293
self.width_lsb = lsb
294294

295-
def set_raw_length(self, msb, lsb):
295+
def _set_raw_length(self, msb, lsb):
296296
self.length_msb = msb
297297
self.length_lsb = lsb
298298

@@ -309,8 +309,8 @@ def __setattr__(self, attr, value):
309309
def __str__(self):
310310
return self.name
311311

312-
def __call__(self, r, ldelay=None, rdelay=None):
313-
return self.next(r, ldelay, rdelay)
312+
def __call__(self, value, blk=False, ldelay=None, rdelay=None):
313+
return self.next(value, blk=blk, ldelay=ldelay, rdelay=rdelay)
314314

315315
#-------------------------------------------------------------------------------
316316
class Input(_Variable): pass
@@ -333,7 +333,7 @@ def dec(self):
333333
return self.sub(1)
334334

335335
class Wire(_Variable):
336-
def add_subst(self, s):
336+
def _add_subst(self, s):
337337
if len(self.subst) > 0:
338338
raise ValueError('Wire %s is already assigned.' % self.name)
339339
self.subst.append(s)
@@ -642,7 +642,7 @@ def __init__(self, var, pos):
642642
def next(self, r):
643643
return Subst(self, r)
644644

645-
def add_subst(self, s):
645+
def _add_subst(self, s):
646646
self.subst.append(s)
647647

648648
def bit_length(self):
@@ -666,7 +666,7 @@ def __init__(self, var, msb, lsb):
666666
def next(self, r):
667667
return Subst(self, r)
668668

669-
def add_subst(self, s):
669+
def _add_subst(self, s):
670670
self.subst.append(s)
671671

672672
def bit_length(self):
@@ -686,7 +686,7 @@ def __init__(self, *vars):
686686
def next(self, r):
687687
return Subst(self, r)
688688

689-
def add_subst(self, s):
689+
def _add_subst(self, s):
690690
self.subst.append(s)
691691

692692
def bit_length(self):
@@ -760,7 +760,7 @@ def __init__(self, left, right, blk=False, ldelay=None, rdelay=None):
760760
self.blk = blk
761761
self.ldelay = ldelay
762762
self.rdelay = rdelay
763-
self.left.add_subst(self)
763+
self.left._add_subst(self)
764764

765765
def _type_check_left(self, left):
766766
if not isinstance(left, VeriloggenNode):

veriloggen/dataflow/dtypes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def _and_vars(*vars):
7070
def _connect_ready(m, var, ready):
7171
if var is None:
7272
return
73-
prev_subst = var.get_subst()
73+
prev_subst = var._get_subst()
7474
if not prev_subst:
7575
m.Assign( var(ready) )
7676
elif isinstance(prev_subst[0].right, vtypes.Int) and (prev_subst[0].right.value==1):

veriloggen/pipeline/pipeline.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ def make_output(self):
373373
ready = vtypes.Int(1)
374374

375375
if ovar.ready is not None:
376-
prev_subst = ovar.ready.get_subst()
376+
prev_subst = ovar.ready._get_subst()
377377
if len(prev_subst) == 0:
378378
ovar.df.m.Assign( ovar.ready(ready) )
379379
elif isinstance(prev_subst[0].right, vtypes.Int) and (prev_subst[0].right.value==1):

veriloggen/verilog/from_verilog.py

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ def visit_Input(self, node):
184184
signed = node.signed
185185
obj = vtypes.Input(width, signed=signed, name=name)
186186
if node.width is not None:
187-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
187+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
188188
self.add_object(obj)
189189
return obj
190190

@@ -194,7 +194,7 @@ def visit_Output(self, node):
194194
signed = node.signed
195195
obj = vtypes.Output(width, signed=signed, name=name)
196196
if node.width is not None:
197-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
197+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
198198
self.add_object(obj)
199199
return obj
200200

@@ -204,7 +204,7 @@ def visit_Inout(self, node):
204204
signed = node.signed
205205
obj = vtypes.Inout(width, signed=signed, name=name)
206206
if node.width is not None:
207-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
207+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
208208
self.add_object(obj)
209209
return obj
210210

@@ -214,7 +214,7 @@ def visit_Tri(self, node):
214214
signed = node.signed
215215
obj = vtypes.Tri(width, signed=signed, name=name)
216216
if node.width is not None:
217-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
217+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
218218
self.add_object(obj)
219219
return obj
220220

@@ -224,7 +224,7 @@ def visit_Wire(self, node):
224224
signed = node.signed
225225
obj = vtypes.Wire(width, signed=signed, name=name)
226226
if node.width is not None:
227-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
227+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
228228
self.add_object(obj)
229229
return obj
230230

@@ -234,7 +234,7 @@ def visit_Reg(self, node):
234234
signed = node.signed
235235
obj = vtypes.Reg(width, signed=signed, name=name)
236236
if node.width is not None:
237-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
237+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
238238
self.add_object(obj)
239239
return obj
240240

@@ -245,8 +245,8 @@ def visit_WireArray(self, node):
245245
signed = node.signed
246246
obj = vtypes.Wire(width, length=length, signed=signed, name=name)
247247
if node.width is not None:
248-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
249-
obj.set_raw_length(self.visit(node.length.msb), self.visit(node.length.lsb))
248+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
249+
obj._set_raw_length(self.visit(node.length.msb), self.visit(node.length.lsb))
250250
self.add_object(obj)
251251
return obj
252252

@@ -257,8 +257,8 @@ def visit_RegArray(self, node):
257257
signed = node.signed
258258
obj = vtypes.Reg(width, length=length, signed=signed, name=name)
259259
if node.width is not None:
260-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
261-
obj.set_raw_length(self.visit(node.length.msb), self.visit(node.length.lsb))
260+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
261+
obj._set_raw_length(self.visit(node.length.msb), self.visit(node.length.lsb))
262262
self.add_object(obj)
263263
return obj
264264

@@ -268,7 +268,7 @@ def visit_Integer(self, node):
268268
signed = node.signed
269269
obj = vtypes.Integer(width, signed=signed, name=name)
270270
if node.width is not None:
271-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
271+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
272272
self.add_object(obj)
273273
return obj
274274

@@ -277,7 +277,7 @@ def visit_Real(self, node):
277277
width = self.visit(node.width) if node.width is not None else None
278278
obj = vtypes.Real(width, name=name)
279279
if node.width is not None:
280-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
280+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
281281
self.add_object(obj)
282282
return obj
283283

@@ -286,7 +286,7 @@ def visit_Genvar(self, node):
286286
width = self.visit(node.width) if node.width is not None else None
287287
obj = vtypes.Genvar(width, name=name)
288288
if node.width is not None:
289-
obj.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
289+
obj._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
290290
self.add_object(obj)
291291
return obj
292292

@@ -302,7 +302,7 @@ def visit_Parameter(self, node):
302302
signed = node.signed
303303
param = vtypes.Parameter(value, width, signed, name=name)
304304
if node.width is not None:
305-
param.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
305+
param._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
306306
self.add_object(param)
307307
return param
308308

@@ -313,7 +313,7 @@ def visit_Localparam(self, node):
313313
signed = node.signed
314314
param = vtypes.Localparam(value, width, signed, name=name)
315315
if node.width is not None:
316-
param.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
316+
param._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
317317
self.add_object(param)
318318
return param
319319

@@ -324,7 +324,7 @@ def visit_Supply(self, node):
324324
signed = node.signed
325325
param = vtypes.Supply(value, width, signed, name=name)
326326
if node.width is not None:
327-
param.set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
327+
param._set_raw_width(self.visit(node.width.msb), self.visit(node.width.lsb))
328328
self.add_object(param)
329329
return param
330330

@@ -688,7 +688,7 @@ def visit_Function(self, node):
688688
width = self.visit(node.retwidth) if node.retwidth is not None else None
689689
func = function.Function(name, width)
690690
if node.retwidth is not None:
691-
func.set_raw_width(self.visit(node.retwidth.msb), self.visit(node.retwidth.lsb))
691+
func._set_raw_width(self.visit(node.retwidth.msb), self.visit(node.retwidth.lsb))
692692
statement = [ self.visit(s) for s in node.statement ]
693693
body = []
694694

@@ -698,15 +698,15 @@ def visit_Function(self, node):
698698
if isinstance(d, vtypes.Input):
699699
t = func.Input(d.name, d.width, d.length, d.signed, d.value)
700700
if d.width_msb is not None and d.width_lsb is not None:
701-
t.set_raw_width(d.width_msb, d.width_lsb)
701+
t._set_raw_width(d.width_msb, d.width_lsb)
702702
elif isinstance(d, vtypes.Reg):
703703
t = func.Reg(d.name, d.width, d.length, d.signed, d.value)
704704
if d.width_msb is not None and d.width_lsb is not None:
705-
t.set_raw_width(d.width_msb, d.width_lsb)
705+
t._set_raw_width(d.width_msb, d.width_lsb)
706706
elif isinstance(d, vtypes.Integer):
707707
t = func.Integer(d.name, d.width, d.length, d.signed, d.value)
708708
if d.width_msb is not None and d.width_lsb is not None:
709-
t.set_raw_width(d.width_msb, d.width_lsb)
709+
t._set_raw_width(d.width_msb, d.width_lsb)
710710
else:
711711
body.append(s)
712712
else:
@@ -741,15 +741,15 @@ def visit_Task(self, node):
741741
if isinstance(d, vtypes.Input):
742742
t = _task.Input(d.name, d.width, d.length, d.signed, d.value)
743743
if d.width_msb is not None and d.width_lsb is not None:
744-
t.set_raw_width(d.width_msb, d.width_lsb)
744+
t._set_raw_width(d.width_msb, d.width_lsb)
745745
elif isinstance(d, vtypes.Reg):
746746
t = _task.Reg(d.name, d.width, d.length, d.signed, d.value)
747747
if d.width_msb is not None and d.width_lsb is not None:
748-
t.set_raw_width(d.width_msb, d.width_lsb)
748+
t._set_raw_width(d.width_msb, d.width_lsb)
749749
elif isinstance(d, vtypes.Integer):
750750
t = _task.Integer(d.name, d.width, d.length, d.signed, d.value)
751751
if d.width_msb is not None and d.width_lsb is not None:
752-
t.set_raw_width(d.width_msb, d.width_lsb)
752+
t._set_raw_width(d.width_msb, d.width_lsb)
753753
else:
754754
body.append(s)
755755
else:

0 commit comments

Comments
 (0)