Skip to content

Commit e7cb15a

Browse files
committed
minor: Remove dims_fft deprecation and add message
1 parent 2e2fe15 commit e7cb15a

File tree

5 files changed

+1
-48
lines changed

5 files changed

+1
-48
lines changed

MIGRATION_V1_V2.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ should be used as a checklist when converting a piece of code using PyLops from
1212
- `utils.dottest`: Change `tol` into `rtol`. Absolute tolerance is now also supported via the keyword `atol`.
1313
When calling it with purely positional arguments, note that after `rtol` comes now first `atol` before `complexflag`.
1414
When using `raiseerror=True` it now emits an `AttributeError` instead of a `ValueError`.
15+
- `dims_fft` in the FFT operators is deprecated in favor of `dimsd`.

pylops/signalprocessing/FFT.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -484,10 +484,6 @@ def FFT(
484484
Shape of the array after the forward, but before linearization.
485485
486486
For example, ``y_reshaped = (Op * x.ravel()).reshape(Op.dimsd)``.
487-
dims_fft : :obj:`tuple`
488-
489-
.. deprecated:: 2.0.0
490-
Use ``dimsd`` instead.
491487
f : :obj:`numpy.ndarray`
492488
Discrete Fourier Transform sample frequencies
493489
real : :obj:`bool`

pylops/signalprocessing/FFT2D.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -316,10 +316,6 @@ def FFT2D(
316316
Shape of the array after the forward, but before linearization.
317317
318318
For example, ``y_reshaped = (Op * x.ravel()).reshape(Op.dimsd)``.
319-
dims_fft : :obj:`tuple`
320-
321-
.. deprecated:: 2.0.0
322-
Use ``dimsd`` instead.
323319
f1 : :obj:`numpy.ndarray`
324320
Discrete Fourier Transform sample frequencies along ``axes[0]``
325321
f2 : :obj:`numpy.ndarray`

pylops/signalprocessing/FFTND.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,10 +305,6 @@ def FFTND(
305305
Shape of the array after the forward, but before linearization.
306306
307307
For example, ``y_reshaped = (Op * x.ravel()).reshape(Op.dimsd)``.
308-
dims_fft : :obj:`tuple`
309-
310-
.. deprecated:: 2.0.0
311-
Use ``dimsd`` instead.
312308
fs : :obj:`tuple`
313309
Each element of the tuple corresponds to the Discrete Fourier Transform
314310
sample frequencies along the respective direction given by ``axes``.

pylops/signalprocessing/_BaseFFTs.py

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -119,24 +119,6 @@ def __init__(
119119
self.clinear = False if self.real or np.issubdtype(dtype, np.floating) else True
120120
self.explicit = False
121121

122-
@property
123-
def dims_fft(self):
124-
warnings.warn(
125-
"dims_fft is deprecated in version 2.0.0, use dimsd instead.",
126-
category=DeprecationWarning,
127-
stacklevel=2,
128-
)
129-
return self.dimsd
130-
131-
@dims_fft.setter
132-
def dims_fft(self, value):
133-
warnings.warn(
134-
"dims_fft is deprecated in version 2.0.0, use dimsd instead.",
135-
category=DeprecationWarning,
136-
stacklevel=2,
137-
)
138-
self.dimsd = value
139-
140122
def _matvec(self, x):
141123
raise NotImplementedError(
142124
"_BaseFFT does not provide _matvec. It must be implemented separately."
@@ -292,24 +274,6 @@ def __init__(
292274
self.clinear = False if self.real or np.issubdtype(dtype, np.floating) else True
293275
self.explicit = False
294276

295-
@property
296-
def dims_fft(self):
297-
warnings.warn(
298-
"dims_fft is deprecated in version 2.0.0, use dimsd instead.",
299-
category=DeprecationWarning,
300-
stacklevel=2,
301-
)
302-
return self.dimsd
303-
304-
@dims_fft.setter
305-
def dims_fft(self, value):
306-
warnings.warn(
307-
"dims_fft is deprecated in version 2.0.0, use dimsd instead.",
308-
category=DeprecationWarning,
309-
stacklevel=2,
310-
)
311-
self.dimsd = value
312-
313277
def _matvec(self, x):
314278
raise NotImplementedError(
315279
"_BaseFFT does not provide _matvec. It must be implemented separately."

0 commit comments

Comments
 (0)