Skip to content

Commit 5e72a73

Browse files
author
Andrew J Westlake
committed
Fixed once_cell version for MSRV
1 parent fd45ff3 commit 5e72a73

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ jobs:
142142
cargo update -p indexmap --precise 1.6.2
143143
cargo update -p parking_lot:0.12.1 --precise 0.11.2
144144
cargo update -p async-global-executor --precise 2.2.0
145+
cargo update -p once_cell --precise 1.14.0
145146
146147
- name: Build (no features)
147148
run: cargo build --no-default-features --verbose --target ${{ matrix.platform.rust-target }}

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,10 @@ required-features = ["async-std-runtime", "testing"]
111111

112112
[dependencies]
113113
async-channel = { version = "1.6", optional = true }
114-
clap = { version = "3.1.5", optional = true }
114+
clap = { version = "4.0.10", optional = true }
115115
futures = "0.3"
116116
inventory = { version = "0.3", optional = true }
117-
once_cell = "=1.14"
117+
once_cell = "1.14"
118118
pin-project-lite = "0.2"
119119
pyo3 = "0.17"
120120
pyo3-asyncio-macros = { path = "pyo3-asyncio-macros", version = "=0.17.0", optional = true }

src/generic.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -310,17 +310,13 @@ fn cancelled(future: &PyAny) -> PyResult<bool> {
310310
future.getattr("cancelled")?.call0()?.is_true()
311311
}
312312

313-
fn done(future: &PyAny) -> PyResult<bool> {
314-
future.getattr("done")?.call0()?.is_true()
315-
}
316-
317313
#[pyclass]
318314
struct CheckedCompletor;
319315

320316
#[pymethods]
321317
impl CheckedCompletor {
322318
fn __call__(&self, future: &PyAny, complete: &PyAny, value: &PyAny) -> PyResult<()> {
323-
if done(future)? {
319+
if cancelled(future)? {
324320
return Ok(());
325321
}
326322

src/testing.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ pub fn parse_args() -> Args {
240240
.get_matches();
241241

242242
Args {
243-
filter: matches.value_of("TESTNAME").map(|name| name.to_string()),
243+
filter: matches.get_one::<String>("TESTNAME").map(|name| name.clone()),
244244
}
245245
}
246246

0 commit comments

Comments
 (0)