Skip to content

Commit a4a15a0

Browse files
author
Andrew J Westlake
committed
Updated MSRV info/workflow since it seems 'bitflags', a dependency of 'clap', is now locked at MSRV 1.46
1 parent 8144e25 commit a4a15a0

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,10 @@ jobs:
9494
- name: Build (no features)
9595
run: cargo build --no-default-features --verbose --target ${{ matrix.platform.rust-target }}
9696

97-
# Omit async-std-runtime feature for MSRV 1.45.0
97+
# Omit async-std-runtime and testing features from MSRV 1.45.0 (See README for details)
9898
- if: matrix.rust == '1.45.0'
9999
name: Prepare 1.45.0 features
100-
run: echo features=testing,attributes,tokio-runtime >> $GITHUB_ENV
100+
run: echo features=attributes,tokio-runtime >> $GITHUB_ENV
101101

102102
# Use all features for MSRV 1.46.0 and above
103103
- if: matrix.rust != '1.45.0'

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -622,6 +622,7 @@ __Before you get started, I personally recommend taking a look at [Event Loop Re
622622
This library can give spurious failures during finalization prior to PyO3 release `v0.13.2`. Make sure your PyO3 dependency is up-to-date!
623623

624624
## MSRV
625-
Currently the MSRV for this library is 1.46.0, _but_ if you don't need to use the `async-std-runtime`
626-
feature, you can use rust 1.45.0.
625+
Currently the MSRV for this library is 1.46.0, _but_ if you don't need to use the `async-std-runtime`
626+
or `testing` features, you can still use rust 1.45.0.
627627
> `async-std` depends on `socket2` which fails to compile under 1.45.0.
628+
> `testing` indirectly relies on `bitflags` through `clap`, which is now locked in at MSRV 1.46.0

0 commit comments

Comments
 (0)