Impl time crate into pyo3 (#5057)

* First draft for implementing time crate into PyO3

* Refactor FromPyObject for PrimitiveDateTime. Disable proptest

* Refactor FromPyObject for OffsetDateTime and UtcDateTime

* Create extract_date_time function for reusable code

* Fix all proptests

* Fix doc test

* Add changelog

* Downgrade time crate version for msrv. Fix clippy error

* Remove UtcDateTime

* Fix fmt CI failure

* Bring back UtcDateTime. Bump time crate to 0.3.38. Add features doc.

* Add time feature to noxfile

* use timezone_utc. add const SECONDS_PER_DAY. Revise doc example

* Fix FromPyObject for UtcDateTime

* `intern` only used on limited api

---------

Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>

Author: Owen-CH-Leung

Cargo.toml

@@ -45,6 +45,7 @@ num-bigint = { version = "0.4.2", optional = true }
 num-complex = { version = ">= 0.4.6, < 0.5", optional = true }
 num-rational = { version = "0.4.1", optional = true }
 rust_decimal = { version = "1.15", default-features = false, optional = true }
+time = { version = "0.3.38", default-features = false, optional = true }
 serde = { version = "1.0", optional = true }
 smallvec = { version = "1.0", optional = true }
 uuid = { version = "1.11.0", optional = true  }

guide/src/features.md

@@ -184,6 +184,17 @@ Adds a dependency on [num-rational](https://docs.rs/num-rational) and enables co
 
 Adds a dependency on [rust_decimal](https://docs.rs/rust_decimal) and enables conversions into its [`Decimal`](https://docs.rs/rust_decimal/latest/rust_decimal/struct.Decimal.html) type.
 
+### `time`
+
+Adds a dependency on [time](https://docs.rs/time) and requires MSRV 1.67.1. Enables conversions between [time](https://docs.rs/time)'s types and Python:
+- [Date](https://docs.rs/time/0.3.38/time/struct.Date.html) -> [`PyDate`]({{#PYO3_DOCS_URL}}/pyo3/types/struct.PyDate.html)
+- [Time](https://docs.rs/time/0.3.38/time/struct.Time.html) -> [`PyTime`]({{#PYO3_DOCS_URL}}/pyo3/types/struct.PyTime.html)
+- [OffsetDateTime](https://docs.rs/time/0.3.38/time/struct.OffsetDateTime.html) -> [`PyDateTime`]({{#PYO3_DOCS_URL}}/pyo3/types/struct.PyDateTime.html)
+- [PrimitiveDateTime](https://docs.rs/time/0.3.38/time/struct.PrimitiveDateTime.html) -> [`PyDateTime`]({{#PYO3_DOCS_URL}}/pyo3/types/struct.PyDateTime.html)
+- [Duration](https://docs.rs/time/0.3.38/time/struct.Duration.html) -> [`PyDelta`]({{#PYO3_DOCS_URL}}/pyo3/types/struct.PyDelta.html)
+- [UtcOffset](https://docs.rs/time/0.3.38/time/struct.UtcOffset.html) -> [`PyTzInfo`]({{#PYO3_DOCS_URL}}/pyo3/types/struct.PyTzInfo.html)
+- [UtcDateTime](https://docs.rs/time/0.3.38/time/struct.UtcDateTime.html) -> [`PyDateTime`]({{#PYO3_DOCS_URL}}/pyo3/types/struct.PyDateTime.html)
+
 ### `serde`
 
 Enables (de)serialization of `Py<T>` objects via [serde](https://serde.rs/).

newsfragments/5057.added.md

@@ -0,0 +1 @@
+Integrate `time` crate into PyO3

noxfile.py

@@ -101,9 +101,9 @@ def test_rust(session: nox.Session):
     if not FREE_THREADED_BUILD:
         _run_cargo_test(session, features="abi3")
     if "skip-full" not in session.posargs:
-        _run_cargo_test(session, features="full jiff-02")
+        _run_cargo_test(session, features="full jiff-02 time")
         if not FREE_THREADED_BUILD:
-            _run_cargo_test(session, features="abi3 full jiff-02")
+            _run_cargo_test(session, features="abi3 full jiff-02 time")
 
 
 @nox.session(name="test-py", venv_backend="none")
@@ -429,6 +429,10 @@ def docs(session: nox.Session) -> None:
 
     features = "full"
 
+    if get_rust_version()[:2] >= (1, 67):
+        # time needs MSRC 1.67+
+        features += ",time"
+
     if get_rust_version()[:2] >= (1, 70):
         # jiff needs MSRC 1.70+
         features += ",jiff-02"
@@ -819,8 +823,8 @@ def update_ui_tests(session: nox.Session):
     env["TRYBUILD"] = "overwrite"
     command = ["test", "--test", "test_compile_error"]
     _run_cargo(session, *command, env=env)
-    _run_cargo(session, *command, "--features=full,jiff-02", env=env)
-    _run_cargo(session, *command, "--features=abi3,full,jiff-02", env=env)
+    _run_cargo(session, *command, "--features=full,jiff-02,time", env=env)
+    _run_cargo(session, *command, "--features=abi3,full,jiff-02,time", env=env)
 
 
 @nox.session(name="test-introspection")
@@ -891,6 +895,10 @@ def _get_feature_sets() -> Generator[Tuple[str, ...], None, None]:
         # multiple-pymethods not supported on wasm
         features += ",multiple-pymethods"
 
+    if get_rust_version()[:2] >= (1, 67):
+        # time needs MSRC 1.67+
+        features += ",time"
+
     if get_rust_version()[:2] >= (1, 70):
         # jiff needs MSRC 1.70+
         features += ",jiff-02"

src/conversions/mod.rs

@@ -16,4 +16,5 @@ pub mod rust_decimal;
 pub mod serde;
 pub mod smallvec;
 mod std;
+pub mod time;
 pub mod uuid;