Code review feedback

Author: Tpt

src/types/any.rs

@@ -40,6 +40,7 @@ fn PyObject_Check(_: *mut ffi::PyObject) -> c_int {
     1
 }
 
+// We follow stub writing guidelines and use "object" instead of "typing.Any": https://typing.python.org/en/latest/guides/writing_stubs.html#using-any
 pyobject_native_type_info!(
     PyAny,
     pyobject_native_static_type_object!(ffi::PyBaseObject_Type),

src/types/mod.rs

@@ -147,6 +147,44 @@ macro_rules! pyobject_native_static_type_object(
 /// - `$typeobject` must be a function that produces a valid `*mut PyTypeObject`
 /// - `$checkfunction` must be a function that accepts arbitrary `*mut PyObject` and returns true /
 ///   false according to whether the object is an instance of the type from `$typeobject`
+#[cfg(not(feature = "experimental-inspect"))]
+#[doc(hidden)]
+#[macro_export]
+macro_rules! pyobject_native_type_info(
+    ($name:ty, $typeobject:expr, $module:expr, $python_name:expr $(, #checkfunction=$checkfunction:path)? $(;$generics:ident)*) => {
+        // SAFETY: macro caller has upheld the safety contracts
+        unsafe impl<$($generics,)*> $crate::type_object::PyTypeInfo for $name {
+            const NAME: &'static str = stringify!($name);
+            const MODULE: ::std::option::Option<&'static str> = ::std::option::Option::Some($module);
+
+            #[inline]
+            #[allow(clippy::redundant_closure_call)]
+            fn type_object_raw(py: $crate::Python<'_>) -> *mut $crate::ffi::PyTypeObject {
+                $typeobject(py)
+            }
+
+            $(
+                #[inline]
+                fn is_type_of(obj: &$crate::Bound<'_, $crate::PyAny>) -> bool {
+                    #[allow(unused_unsafe, reason = "not all `$checkfunction` are unsafe fn")]
+                    // SAFETY: `$checkfunction` is being called with a valid `PyObject` pointer
+                    unsafe { $checkfunction(obj.as_ptr()) > 0 }
+                }
+            )?
+        }
+
+        impl $name {
+            #[doc(hidden)]
+            pub const _PYO3_DEF: $crate::impl_::pymodule::AddTypeToModule<Self> = $crate::impl_::pymodule::AddTypeToModule::new();
+
+            #[allow(dead_code)]
+            #[doc(hidden)]
+            pub const _PYO3_INTROSPECTION_ID: &'static str = concat!(stringify!($module), stringify!($name));
+        }
+    };
+);
+
+#[cfg(feature = "experimental-inspect")]
 #[doc(hidden)]
 #[macro_export]
 macro_rules! pyobject_native_type_info(
@@ -155,7 +193,6 @@ macro_rules! pyobject_native_type_info(
         unsafe impl<$($generics,)*> $crate::type_object::PyTypeInfo for $name {
             const NAME: &'static str = stringify!($name);
             const MODULE: ::std::option::Option<&'static str> = ::std::option::Option::Some($module);
-            #[cfg(feature = "experimental-inspect")]
             const TYPE_HINT: $crate::inspect::TypeHint = $crate::inspect::TypeHint::module_attr($module, $python_name);
 
             #[inline]