GIL during module init?

[dimaqq]

Rust compiler accept both versions, tested with pyo3 0.24.2:

Using module's py:

/// 🐍Lightweight OTEL span to binary converter, written in Rust🦀
#[pymodule(gil_used = false)]
fn otlp_proto(m: &Bound<'_, PyModule>) -> PyResult<()> {
    m.add_function(wrap_pyfunction!(encode_spans, m)?)?;
    m.add(
        "CONTENT_TYPE",
        PyString::new(m.py(), "application/x-protobuf"),
    )
}

Entering GIL to get py:

/// 🐍Lightweight OTEL span to binary converter, written in Rust🦀
#[pymodule(gil_used = false)]
fn otlp_proto(m: &Bound<'_, PyModule>) -> PyResult<()> {
    m.add_function(wrap_pyfunction!(encode_spans, m)?)?;
    Python::with_gil(|py| m.add("CONTENT_TYPE", PyString::new(py, "application/x-protobuf")))
}

Are both actually legal?

[mejrs]

That's fine, the gil is re-entrant so you can nest calls to with_gil if you want. That said if there's already a Python token or something with a py() method in scope, you should use that instead because it's zero cost.

[dimaqq]

That's fine, the gil is re-entrant so you can nest calls to with_gil if you want. That said if there's already a Python token or something with a py() method in scope, you should use that instead because it's zero cost.

Thank, I'm using this now:

/// 🐍Lightweight OTEL span to binary converter, written in Rust🦀
#[pymodule(gil_used = false)]
fn otlp_proto(m: &Bound<'_, PyModule>) -> PyResult<()> {
    Python::with_gil(|py| -> PyResult<()> {
        m.add("CONTENT_TYPE", PyString::new(py, "application/x-protobuf"))?;
        m.add("builtins", py.import("builtins")?)?;
        m.add("functools", py.import("functools")?)?;
        m.add("abc", py.import("collections.abc")?)?;
        Ok(())
    })?;
    m.add_function(wrap_pyfunction!(encode_spans, m)?)?;
    m.add_function(wrap_pyfunction!(test_tuple, m)?)?;
    m.add_function(wrap_pyfunction!(_linearise, m)?)?;
    Ok(())
}