Handle errors on PyIterator when calling size_hint
#5604
Merged
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
force-pushed
the
iter_size_hint_error
branch
from
827a752 to
4129275
Compare
bschoenmaeckers
force-pushed
the
iter_size_hint_error
branch
from
9fe9a61 to
ae20ab2
Compare
davidhewitt
reviewed
Nov 8, 2025
| fn test_size_hint(obj: &crate::Bound<'_, crate::PyAny>) { | ||
| let iter = obj.cast::<PyIterator>().unwrap(); | ||
| assert_eq!((0, None), iter.size_hint()); | ||
| assert!(PyErr::take(obj.py()).is_none()); |
Member
There was a problem hiding this comment.
Perhaps use UnraisableCapture to demonstrate that the error was sent to sys.unraisablehook?
Member
Author
There was a problem hiding this comment.
Thanks! Did not know yet about this utility.
bschoenmaeckers
force-pushed
the
iter_size_hint_error
branch
2 times, most recently
from
222389a to
8c5d609
Compare
bschoenmaeckers
force-pushed
the
iter_size_hint_error
branch
from
8c5d609 to
d9de53e
Compare
bschoenmaeckers
force-pushed
the
iter_size_hint_error
branch
from
30831fb to
a5576aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5595