Finish migration of error.rs

This commit finishes the migration of error.rs to use the new exception
API in 0.12.0. Most of the work was done on this, just a few little
pieces that needed to be updated to conform to the new api.

Author: mtreinish

src/error.rs

@@ -1,6 +1,6 @@
 //! Defines error types.
 use crate::types::DataType;
-use pyo3::{exceptions as exc, PyErr, PyErrArguments, PyErrValue, PyObject, Python, ToPyObject};
+use pyo3::{exceptions as exc, PyErr, PyErrArguments, PyObject, Python, ToPyObject};
 use std::fmt;
 
 /// Represents a dimension and dtype of numpy array.
@@ -63,14 +63,14 @@ macro_rules! impl_pyerr {
         impl std::error::Error for $err_type {}
 
         impl PyErrArguments for $err_type {
-            fn arguments(&self, py: Python) -> PyObject {
+            fn arguments(self, py: Python) -> PyObject {
                 format!("{}", self).to_object(py)
             }
         }
 
         impl std::convert::From<$err_type> for PyErr {
             fn from(err: $err_type) -> PyErr {
-                PyErr::from_value::<exc::PyTypeError>(PyErrValue::from_err_args(err))
+                exc::PyTypeError::new_err(err)
             }
         }
     };