Skip to content

Commit 6cd2a84

Browse files
jakelishmandavidhewitt
authored andcommitted
Re-enable builds on 32-bit Windows
The parent commit fixes the problems with 32-bit Windows, this one simply re-enables the build and re-activates the CI runs of it.
1 parent 64145d2 commit 6cd2a84

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

.github/workflows/ci.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,11 @@ jobs:
4848
python-architecture: "x64",
4949
rust-target: "x86_64-pc-windows-msvc",
5050
},
51+
{
52+
os: "windows-latest",
53+
python-architecture: "x86",
54+
rust-target: "i686-pc-windows-msvc",
55+
},
5156
]
5257
include:
5358
# ubuntu-24.04 does not support 3.7
@@ -141,6 +146,11 @@ jobs:
141146
python-architecture: "x64",
142147
rust-target: "x86_64-pc-windows-msvc",
143148
},
149+
{
150+
os: "windows-latest",
151+
python-architecture: "x86",
152+
rust-target: "i686-pc-windows-msvc",
153+
},
144154
]
145155
include:
146156
# ubuntu-24.04 does not support 3.7
@@ -181,6 +191,7 @@ jobs:
181191
nox -f examples/simple/noxfile.py
182192
env:
183193
CARGO_TERM_VERBOSE: true
194+
CARGO_BUILD_TARGET: ${{ matrix.platform.rust-target }}
184195
RUST_BACKTRACE: 1
185196

186197
cross-build:

src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,6 @@ as well as the [`PyReadonlyArray::try_as_matrix`] and [`PyReadwriteArray::try_as
7474
// and similar aren't constructible
7575
#![cfg_attr(feature = "gil-refs", deny(missing_debug_implementations))]
7676

77-
#[cfg(all(target_os = "windows", target_arch = "x86"))]
78-
compile_error!("Compilation for 32-bit windows is not currently supported. See https://github.com/PyO3/rust-numpy/issues/448");
79-
8077
pub mod array;
8178
mod array_like;
8279
pub mod borrow;

0 commit comments

Comments
 (0)