Skip to content

Commit ea88df3

Browse files
committed
Fix use of deprecated constructors in benchmarks
1 parent 9d7882f commit ea88df3

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

benches/array.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,48 +6,48 @@ use test::{black_box, Bencher};
66
use std::ops::Range;
77

88
use numpy::{PyArray1, PyArray2, PyArray3};
9-
use pyo3::{PyAny, Python, ToPyObject};
9+
use pyo3::{types::PyAnyMethods, Python, ToPyObject};
1010

1111
#[bench]
1212
fn extract_success(bencher: &mut Bencher) {
1313
Python::with_gil(|py| {
14-
let any: &PyAny = PyArray2::<f64>::zeros(py, (10, 10), false);
14+
let any = PyArray2::<f64>::zeros_bound(py, (10, 10), false).into_any();
1515

1616
bencher.iter(|| {
17-
black_box(any).extract::<&PyArray2<f64>>().unwrap();
17+
black_box(&any).extract::<&PyArray2<f64>>().unwrap();
1818
});
1919
});
2020
}
2121

2222
#[bench]
2323
fn extract_failure(bencher: &mut Bencher) {
2424
Python::with_gil(|py| {
25-
let any: &PyAny = PyArray2::<i32>::zeros(py, (10, 10), false);
25+
let any = PyArray2::<f64>::zeros_bound(py, (10, 10), false).into_any();
2626

2727
bencher.iter(|| {
28-
black_box(any).extract::<&PyArray2<f64>>().unwrap_err();
28+
black_box(&any).extract::<&PyArray2<f64>>().unwrap_err();
2929
});
3030
});
3131
}
3232

3333
#[bench]
3434
fn downcast_success(bencher: &mut Bencher) {
3535
Python::with_gil(|py| {
36-
let any: &PyAny = PyArray2::<f64>::zeros(py, (10, 10), false);
36+
let any = PyArray2::<f64>::zeros_bound(py, (10, 10), false).into_any();
3737

3838
bencher.iter(|| {
39-
black_box(any).downcast::<PyArray2<f64>>().unwrap();
39+
black_box(&any).downcast::<PyArray2<f64>>().unwrap();
4040
});
4141
});
4242
}
4343

4444
#[bench]
4545
fn downcast_failure(bencher: &mut Bencher) {
4646
Python::with_gil(|py| {
47-
let any: &PyAny = PyArray2::<i32>::zeros(py, (10, 10), false);
47+
let any = PyArray2::<f64>::zeros_bound(py, (10, 10), false).into_any();
4848

4949
bencher.iter(|| {
50-
black_box(any).downcast::<PyArray2<f64>>().unwrap_err();
50+
black_box(&any).downcast::<PyArray2<f64>>().unwrap_err();
5151
});
5252
});
5353
}

benches/borrow.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,16 @@
33
extern crate test;
44
use test::{black_box, Bencher};
55

6-
use numpy::PyArray;
6+
use numpy::{PyArray, PyArrayMethods};
77
use pyo3::Python;
88

99
#[bench]
1010
fn initial_shared_borrow(bencher: &mut Bencher) {
1111
Python::with_gil(|py| {
12-
let array = PyArray::<f64, _>::zeros(py, (6, 5, 4, 3, 2, 1), false);
12+
let array = PyArray::<f64, _>::zeros_bound(py, (6, 5, 4, 3, 2, 1), false);
1313

1414
bencher.iter(|| {
15-
let array = black_box(array);
15+
let array = black_box(&array);
1616

1717
let _shared = array.readonly();
1818
});
@@ -22,12 +22,12 @@ fn initial_shared_borrow(bencher: &mut Bencher) {
2222
#[bench]
2323
fn additional_shared_borrow(bencher: &mut Bencher) {
2424
Python::with_gil(|py| {
25-
let array = PyArray::<f64, _>::zeros(py, (6, 5, 4, 3, 2, 1), false);
25+
let array = PyArray::<f64, _>::zeros_bound(py, (6, 5, 4, 3, 2, 1), false);
2626

2727
let _shared = (0..128).map(|_| array.readonly()).collect::<Vec<_>>();
2828

2929
bencher.iter(|| {
30-
let array = black_box(array);
30+
let array = black_box(&array);
3131

3232
let _shared = array.readonly();
3333
});
@@ -37,10 +37,10 @@ fn additional_shared_borrow(bencher: &mut Bencher) {
3737
#[bench]
3838
fn exclusive_borrow(bencher: &mut Bencher) {
3939
Python::with_gil(|py| {
40-
let array = PyArray::<f64, _>::zeros(py, (6, 5, 4, 3, 2, 1), false);
40+
let array = PyArray::<f64, _>::zeros_bound(py, (6, 5, 4, 3, 2, 1), false);
4141

4242
bencher.iter(|| {
43-
let array = black_box(array);
43+
let array = black_box(&array);
4444

4545
let _exclusive = array.readwrite();
4646
});

0 commit comments

Comments
 (0)