use distutils exceptions; add rust version check

Author: fafhrd91

CHANGES.rst

@@ -1,6 +1,14 @@
 CHANGES
 =======
 
+0.3 (2017-xx-xx)
+----------------
+
+- Use distutils exceptions for errors.
+
+- Add rust version check for extension.
+
+
 0.2 (2017-03-08)
 ----------------
 

example/setup.py

@@ -4,8 +4,8 @@
 
 setup(name='hello-rust',
       version='1.0',
-      rust_extensions=[RustExtension('hello_rust._helloworld', 'extensions/Cargo.toml')],
+      rust_extensions=[
+          RustExtension('hello_rust._helloworld', 'extensions/Cargo.toml')],
       packages=['hello_rust'],
       # rust extensions are not zip safe, just like C-extensions.
-      zip_safe=False
-)
+      zip_safe=False)

setup.py

@@ -1,4 +1,4 @@
-from setuptools import setup, find_packages
+from setuptools import setup
 
 version = '0.2'
 
@@ -15,6 +15,7 @@
         (open('README.rst').read(), open('CHANGES.rst').read())),
     license='MIT',
     packages=['setuptools_rust'],
+    install_requires=['semver==2.7.6'],
     zip_safe=True,
     classifiers=[
         "Topic :: Software Development :: Version Control",

setuptools_rust/__init__.py

@@ -7,25 +7,28 @@
 from distutils.cmd import Command
 from distutils.dist import Distribution
 from distutils.command.build import build as Build
-from distutils.command.build_ext import build_ext
-from distutils.command.install_lib import install_lib
-from setuptools import dist, setup, Extension
-from setuptools.command import develop, bdist_egg
+from distutils.errors import (
+    DistutilsExecError, DistutilsFileError, DistutilsPlatformError)
+from setuptools.command import develop
+
+import semver
 
 __all__ = ('RustExtension', 'build_rust')
 
 
 # allow to use 'rust_extensions' parameter for setup() call
 Distribution.rust_extensions = ()
 
+
 def has_ext_modules(self):
     return (self.ext_modules and len(self.ext_modules) > 0 or
             self.rust_extensions and len(self.rust_extensions) > 0)
 
+
 Distribution.has_ext_modules = has_ext_modules
-#dist.Distribution.has_ext_modules = has_ext_modules
 
-# add support for build_rust sub0command
+
+# add support for build_rust sub-command
 def has_rust_extensions(self):
     exts = [ext for ext in self.distribution.rust_extensions
             if isinstance(ext, RustExtension)]
@@ -38,13 +41,15 @@ def has_rust_extensions(self):
 # monkey patch "develop" command
 orig_run_command = develop.develop.run_command
 
+
 def monkey_run_command(self, cmd):
     orig_run_command(self, cmd)
 
     if cmd == 'build_ext':
         self.reinitialize_command('build_rust', inplace=1)
         orig_run_command(self, 'build_rust')
 
+
 develop.develop.run_command = monkey_run_command
 
 
@@ -60,18 +65,33 @@ class RustExtension:
         path to the cargo.toml manifest
       args : [stirng]
         a list of extra argumenents to be passed to cargo.
+      version : string
+        rust compiler version
       quiet : bool
         If True, doesn't echo cargo's output.
       debug : bool
         Controls whether --debug or --release is passed to cargo.
     """
 
-    def __init__(self, name, path, args=None, quiet=False, debug=False):
-        self.name=name
-        self.path=path
-        self.args=args
-        self.quiet=quiet
-        self.debug=debug
+    def __init__(self, name, path,
+                 args=None, version=None, quiet=False, debug=False):
+        self.name = name
+        self.path = path
+        self.args = args
+        self.version = version
+        self.quiet = quiet
+        self.debug = debug
+
+    @staticmethod
+    def get_version():
+        env = os.environ.copy()
+        try:
+            output = subprocess.check_output(["rustc", "-V"], env=env)
+            return output.split(' ')[1]
+        except subprocess.CalledProcessError:
+            return None
+        except OSError:
+            return None
 
 
 class build_rust(Command):
@@ -99,12 +119,13 @@ def finalize_options(self):
 
     def features(self):
         version = sys.version_info
-        if (2,7) < version < (2,8):
+        if (2, 7) < version < (2, 8):
             return "python27-sys"
-        elif (3,3) < version:
+        elif (3, 3) < version:
             return "python3-sys"
         else:
-            raise ValueError("Unsupported python version: %s" % sys.version)
+            raise DistutilsPlatformError(
+                "Unsupported python version: %s" % sys.version)
 
     def build_extension(self, ext):
         # Make sure that if pythonXX-sys is used, it builds against the current
@@ -120,6 +141,10 @@ def build_extension(self, ext):
             "PATH":  bindir + os.pathsep + os.environ.get("PATH", "")
         })
 
+        if not os.path.exists(ext.path):
+            raise DistutilsFileError(
+                "Can not file rust extension project file: %s" % ext.path)
+
         # Execute cargo.
         try:
             args = (["cargo", "build", "--manifest-path", ext.path,
@@ -130,11 +155,12 @@ def build_extension(self, ext):
                 print(" ".join(args), file=sys.stderr)
                 output = subprocess.check_output(args, env=env)
         except subprocess.CalledProcessError as e:
-            msg = "cargo failed with code: %d\n%s" % (e.returncode, e.output)
-            raise Exception(msg)
+            raise DistutilsExecError(
+                "cargo failed with code: %d\n%s" % (e.returncode, e.output))
         except OSError:
-            raise Exception("Unable to execute 'cargo' - this package "
-                            "requires rust to be installed and cargo to be on the PATH")
+            raise DistutilsExecError(
+                "Unable to execute 'cargo' - this package "
+                "requires rust to be installed and cargo to be on the PATH")
 
         if not ext.quiet:
             print(output, file=sys.stderr)
@@ -158,7 +184,7 @@ def build_extension(self, ext):
         try:
             dylib_path = glob.glob(os.path.join(target_dir, wildcard_so))[0]
         except IndexError:
-            raise Exception(
+            raise DistutilsExecError(
                 "rust build failed; unable to find any .dylib in %s" %
                 target_dir)
 
@@ -179,5 +205,15 @@ def build_extension(self, ext):
         shutil.copyfile(dylib_path, ext_path)
 
     def run(self):
+        version = RustExtension.get_version()
+        if self.extensions and version is None:
+            raise DistutilsPlatformError('Can not find Rust compiler')
+
         for ext in self.extensions:
+            if ext.version is not None:
+                if not semver.match(version, ext.version):
+                    raise DistutilsPlatformError(
+                        "Rust %s does not match extension requirenment %s" % (
+                            version, ext.version))
+
             self.build_extension(ext)