fixed OSX extension compilation

Author: fafhrd91

CHANGES.rst

@@ -4,9 +4,11 @@ CHANGES
 0.3 (2017-04-09)
 ----------------
 
-- Use distutils exceptions for errors.
+- Fixed OSX extension compilation
 
-- Add rust version check for extension.
+- Use distutils exceptions for errors
+
+- Add rust version check for extension
 
 - Cleanup example project
 

example/extensions/src/lib.rs

@@ -1,5 +1,3 @@
-#![crate_type = "dylib"]
-
 #[macro_use] extern crate cpython;
 
 use cpython::{PyObject, PyResult, Python, PyTuple, PyDict};

setuptools_rust/__init__.py

@@ -96,9 +96,9 @@ def finalize_options(self):
     def _cpython_feature(self):
         version = sys.version_info
         if (2, 7) < version < (2, 8):
-            return "cpython/python27-sys"
+            return ("cpython/python27-sys", "cpython/extension-module-2-7")
         elif (3, 3) < version:
-            return "cpython/python3-sys"
+            return ("cpython/python3-sys", "cpython/extension-module")
         else:
             raise DistutilsPlatformError(
                 "Unsupported python version: %s" % sys.version)
@@ -122,17 +122,28 @@ def build_extension(self, ext):
                 "Can not file rust extension project file: %s" % ext.path)
 
         features = set(ext.features)
-        features.add(self._cpython_feature())
+        features.update(self._cpython_feature())
 
-        # Execute cargo.
+        # build cargo command
+        args = (["cargo", "rustc", "--lib", "--manifest-path", ext.path,
+                 "--features", " ".join(features)]
+                + list(ext.args or []))
+        if not ext.debug:
+            args.append("--release")
+
+        args.extend(["--", '--crate-type', 'cdylib'])
+
+        # OSX requires special linker argument
+        if sys.platform == "darwin":
+            args.extend(["-C", "link-arg=-undefined",
+                         "-C", "link-arg=dynamic_lookup"])
+
+        if not ext.quiet:
+            print(" ".join(args), file=sys.stderr)
+
+        # Execute cargo
         try:
-            args = (["cargo", "build", "--manifest-path", ext.path,
-                     "--features", " ".join(features)] + list(ext.args or []))
-            if not ext.debug:
-                args.append("--release")
-            if not ext.quiet:
-                print(" ".join(args), file=sys.stderr)
-                output = subprocess.check_output(args, env=env)
+            output = subprocess.check_output(args, env=env)
         except subprocess.CalledProcessError as e:
             raise CompileError(
                 "cargo failed with code: %d\n%s" % (e.returncode, e.output))
@@ -142,6 +153,8 @@ def build_extension(self, ext):
                 "requires rust to be installed and cargo to be on the PATH")
 
         if not ext.quiet:
+            if isinstance(output, bytes):
+                output = output.decode('latin-1')
             print(output, file=sys.stderr)
 
         # Find the shared library that cargo hopefully produced and copy

setuptools_rust/patch.py

@@ -30,10 +30,8 @@ def has_rust_extensions(self):
 
 
 def monkey_run_command(self, cmd):
-    print(cmd)
     orig_run_command(self, cmd)
 
-    print(cmd)
     if cmd == 'build_ext':
         self.reinitialize_command('build_rust', inplace=1)
         orig_run_command(self, 'build_rust')