Merge pull request #460 from PyO3/release-1.10.1

release: 1.10.1

Author: davidhewitt

.bumpversion.cfg

@@ -1,7 +1,7 @@
 [bumpversion]
 commit = True
 tag = False
-current_version = 1.10.0
+current_version = 1.10.1
 message = release: {new_version}
 
 [bumpversion:file:pyproject.toml]

CHANGELOG.md

@@ -1,6 +1,10 @@
 # Changelog
 
-## 1.10.0 (2024-07-01)
+## 1.10.1 (2024-08-04)
+### Fixed
+- Fix regression in 1.10.0 where editable builds would be built in release mode
+
+## 1.10.0 (2024-08-03)
 ### Packaging
 - Extend macOS build flags to iOS, tvOS and watchOS. [#436](https://github.com/PyO3/setuptools-rust/pull/436)
 - Support Python 3.13. [#446](https://github.com/PyO3/setuptools-rust/pull/446)

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "setuptools-rust"
-version = "1.10.0"
+version = "1.10.1"
 description = "Setuptools Rust extension plugin"
 readme = "README.md"
 requires-python = ">=3.8"

setuptools_rust/build.py

@@ -329,10 +329,7 @@ def build_extension(
     def install_extension(
         self, ext: RustExtension, dylib_paths: List["_BuiltModule"]
     ) -> None:
-        debug_build = ext.debug if ext.debug is not None else self.inplace
-        debug_build = self.debug if self.debug is not None else debug_build
-        if self.release:
-            debug_build = False
+        debug_build = self._is_debug_build(ext)
 
         # Ask build_ext where the shared library would go if it had built it,
         # then copy it there.
@@ -502,8 +499,8 @@ def _detect_rust_target(
     def _is_debug_build(self, ext: RustExtension) -> bool:
         if self.release:
             return False
-        elif self.debug is not None:
-            return self.debug
+        elif self.debug:
+            return True
         elif ext.debug is not None:
             return ext.debug
         else:

setuptools_rust/version.py

@@ -1,4 +1,4 @@
-__version__ = version = "1.10.0"
+__version__ = version = "1.10.1"
 __version_tuple__ = version_tuple = tuple(
     map(lambda x: int(x[1]) if x[0] < 3 else x[1], enumerate(__version__.split(".")))
 )