Address deprecation warnings (#453)

* code: Change default for add_cutout_windspeed

* code: Address rasterio DeprecationWarning on crs.is_valid

* doc: Update release notes

---------

Co-authored-by: Lukas Trippe <[email protected]>

Author: euronion

RELEASE_NOTES.rst

@@ -8,18 +8,26 @@ Release Notes
 #############
 
 
-.. Upcoming Release
-.. ================
+Upcoming Release
+================
 
-.. .. warning:: 
+.. warning:: 
 
-..   The features listed below are not released yet, but will be part of the next release! 
-..   To use the features already you have to install the ``master`` branch, e.g. 
-..   ``pip install git+https://github.com/pypsa/atlite``.
+   The features listed below are not released yet, but will be part of the next release! 
+   To use the features already you have to install the ``master`` branch, e.g. 
+   ``pip install git+https://github.com/pypsa/atlite``.
+
+**Breaking**
+* Set `add_cutout_windspeed = True` as default for `get_windturbineconfig` to ensure that the cutout wind speed is always added to the turbine configuration (`GH #316 <https://github.com/PyPSA/atlite/pull/316>`_);
+  removed the `DeprecationWarning`.
+ 
+**Features**
+* Add new onshore turbine models: eno 126 3.5 MW, eno 126 4 MW, and eno 126 4.8 MW . (turbines that match more closely the PyPSA/technologydata cost assumptions)
 
-* Feature: Add new onshore turbine models: eno 126 3.5 MW, eno 126 4 MW, and eno 126 4.8 MW . (turbines that match more closely the PyPSA/technologydata cost assumptions)
+**Bug fixes**
 * Fix `atlite.Cutout()` to be able to handle the `bounds` argument to be a `DataFrame` in accordance to the docstring (https://github.com/PyPSA/atlite/pull/445).
 * Raise a `FileNotFoundError` if the `temp_dir` explicitly specified for cutout preparation does not exist instead of failing with an obfuscated error message (https://github.com/PyPSA/atlite/pull/445).
+* Addressed `rasterio` DeprecationWarning on `crs.is_valid`.
 
 `v0.4.1 <https://github.com/PyPSA/atlite/releases/tag/v0.4.1>`__ (12th May 2025)
 =======================================================================================

atlite/gis.py

@@ -477,7 +477,9 @@ def open_files(self):
                 raster = rio.open(raster)
             else:
                 assert isinstance(raster, rio.DatasetReader)
-            if not raster.crs.is_valid if raster.crs is not None else True:
+
+            # Check if the raster has a valid CRS
+            if not raster.crs:
                 if d["crs"]:
                     raster._crs = CRS(d["crs"])
                 else:

atlite/resource.py

@@ -11,7 +11,6 @@
 import json
 import logging
 import re
-import warnings
 from operator import itemgetter
 from pathlib import Path
 from typing import TYPE_CHECKING
@@ -49,7 +48,7 @@ class TurbineConfig(TypedDict):
 
 
 def get_windturbineconfig(
-    turbine: str | Path | dict, add_cutout_windspeed: bool = False
+    turbine: str | Path | dict, add_cutout_windspeed: bool = True
 ) -> TurbineConfig:
     """
     Load the wind 'turbine' configuration.
@@ -69,7 +68,7 @@ def get_windturbineconfig(
             a user provided config dict. Needs to have the keys "POW", "V", "P", and
             "hub_height". Values for "POW" and "V" need to be list or np.ndarray with
             equal length.
-    add_cutout_windspeed : bool
+    add_cutout_windspeed : bool = True
         If True and in case the power curve does not end with a zero, will add zero power
         output at the highest wind speed in the power curve. If False, a warning will be
         raised if the power curve does not have a cut-out wind speed.
@@ -80,14 +79,10 @@ def get_windturbineconfig(
         Config with details on the turbine
 
     """
-    assert isinstance(turbine, (str | Path | dict))
-
-    if add_cutout_windspeed is False:
-        msg = (
-            "'add_cutout_windspeed' for wind turbine\npower curves will default to "
-            "True in atlite relase v0.2.15."
+    if not isinstance(turbine, (str | Path | dict)):
+        raise KeyError(
+            f"`turbine` must be a str, pathlib.Path or dict, but is {type(turbine)}."
         )
-        warnings.warn(msg, FutureWarning)
 
     if isinstance(turbine, str) and turbine.startswith("oedb:"):
         conf = get_oedb_windturbineconfig(turbine[len("oedb:") :])