Fix incorrect unit conversion in hydro function in convert.py (#422)

* Fix incorrect unit conversion in hydro function in convert.py

Removed unnecessary factor of 1000/24 from the runoff calculation, as pointed out by user JKALanger.
The function now correctly calculates runoff in m3 per hour
by directly multiplying the depth (in meters per hour) by the basin area (in square meters).

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update release_notes.rst

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: lukasschirren

atlite/convert.py

@@ -1038,9 +1038,7 @@ def hydro(
     # The hydrological parameters are in units of "m of water per day" and so
     # they should be multiplied by 1000 and the basin area to convert to m3
     # d-1 = m3 h-1 / 24
-    runoff *= (1000.0 / 24.0) * xr.DataArray(
-        basins.shapes.to_crs(dict(proj="cea")).area
-    )
+    runoff *= xr.DataArray(basins.shapes.to_crs(dict(proj="cea")).area)
 
     return hydrom.shift_and_aggregate_runoff_for_plants(
         basins, runoff, flowspeed, show_progress

doc/release_notes.rst

@@ -5,3 +5,4 @@
 
 .. include:: ../RELEASE_NOTES.rst
 
+* In ``atlite/convert.py``, the function ``hydro`` is now correctly calculating the runoff in m3 per hour by multiplying the depth (in meters per hour) by the basin area (in m2).