fix mypy issues maybe

Author: RobbieKiwi

doc/release_notes.rst

@@ -3,7 +3,7 @@ Release Notes
 
 .. Upcoming Version
 
-* Allow constant values in objective cost function
+* Allow constant values in objective cost function. Refactored objective setting.
 * Add support for SOS1 and SOS2 (Special Ordered Sets) constraints via ``Model.add_sos_constraints()`` and ``Model.remove_sos_constraints()``
 * Add simplify method to LinearExpression to combine duplicate terms
 * Add convenience function to create LinearExpression from constant

linopy/model.py

@@ -266,7 +266,7 @@ def objective(self) -> Objective:
 
     @objective.setter
     def objective(
-        self, obj: Objective | LinearExpression | QuadraticExpression
+        self, obj: Objective | Variable | LinearExpression | QuadraticExpression
     ) -> Objective:
         self.add_objective(expr=obj, overwrite=True, allow_constant=False)
         return self._objective
@@ -779,7 +779,7 @@ def add_constraints(
         return constraint
 
     @overload
-    def add_objective(
+    def add_objective(  # Set objective as Objective object
         self,
         expr: Objective,
         sense: None = None,
@@ -788,7 +788,7 @@ def add_objective(
     ) -> None: ...
 
     @overload
-    def add_objective(
+    def add_objective(  # Set objective as expression-like with sense
         self,
         expr: Variable
         | LinearExpression
@@ -834,6 +834,9 @@ def add_objective(
                 " Set `overwrite` to True to force overwriting."
             )
 
+        if isinstance(expr, list | tuple):
+            expr: LinearExpression = self.linexpr(*expr)
+
         if isinstance(expr, Objective):
             assert sense is None, "Cannot set sense if objective object is passed"
             objective = expr

linopy/objective.py

@@ -213,14 +213,14 @@ def model(self) -> Model:
         return self._model
 
     @property
-    def sense(self) -> str:
+    def sense(self) -> Literal["min", "max"]:
         """
         Returns the sense of the objective.
         """
         return self._sense
 
     @sense.setter
-    def sense(self, sense: str) -> None:
+    def sense(self, sense: Literal["min", "max"]) -> None:
         """
         Sets the sense of the objective.
         """