-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[ENH] Fix typos in efficient_frontier
#635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#641) fixes all the URLs and `main` branch references after move to new org
* updates `pyprojecet.toml` to admit python 3.13 and 3.14 * extends CI to test python 3.14 and 3.13 * python 3.9 end-of-life
This dockerfile introduced by tschm is really no longer needed. We will work on a modern .devcontainer setup
* introduces limited concurrency for CI jobs, so CI only runs on the newest commit of a branch and cancels other runs, to save runners * forces all started CI runs to conclude by adding `fail-fast: False`
Moves packaging completely to `pyproject.toml` from multiple locations: * `setup.py` * `requirements.txt` * `poetry.lock` No changes to content except where uniformization is requred - e.g., `matplotlib` was inconsistently in the core and optional depset. `pyproject.toml` is the current recommended packaging standard, see https://packaging.python.org/en/latest/guides/writing-pyproject-toml/ Also: * removes `poetry` lockfile and related workflows for now. * updates `checkout` and `setup-python` versions to latest
Also remove a lost workflow in the ISSUE_Template.
typo in CVaR explanation
Towards an updated README file
This PR enables support for plotly 6.
Here we test all notebooks (e.g. we run them from top to bottom) with nbmake. nbmake is a package produced by our friend Alex Remedios, see https://github.com/treebeardtech/nbmake. Please note that we had to update the notebooks following a change in yfinance. We have replaced "Adj Close" with "Close".
* moves linting to `ruff` * adds `editorconfig` * makes tests dependent on passing linting Also fixes linting in some files (but not all).
merges all PR CI jobs into one workflow, which allows gating and conditionals. Also makes all workflows conditional on basic code quality checks to avoid unnecessary runs.
…#662) * adds a CI job, `pytest-nosoftdeps`, to test the package without soft dependencies. * isolates soft dependency `matplotlib` in tests and the plotting module * isolates the `ecos` dependency almost entirely. There is one default that remains, which is deprecated and scheduled for removal in 1.7.0. * adds `scikit-base` soft dependency (without further dependencies) to manage soft dependencies This is also useful to check whether soft dependencies are properly isolated.
restores the `requirements.txt` for downwards compatibility
`scikit-learn` is a soft dependency - this PR fully isolates `scikit-learn` with dependency checks. It is not removed from the core dependency set, even though the dependency is entirely localized in the `CovarianceShrinkage` object, since it seems to be called frequently from the rest of the code base.
fkiraly
approved these changes
Nov 16, 2025
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, strange that this did not get merged
efficient_frontier
fkiraly
added a commit
that referenced
this pull request
Nov 16, 2025
## Summary - fix typo in _validate_returns: DataFrame - fix typo in _make_weight_sum_constraint: provided - normalize whitespace in weight sum check comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
flake8