Fix steps counting (#97)

* fix: Allow AISearcher to pick a step without relying on stepsPlayed

* feat: Add sending of steps count

* Rename PathCondition according to client's naming

* Revert "Rename PathCondition according to client's naming"

This reverts commit e9cb375.

* Fix AISearcher bug with stepsPlayed

Author: Parzival-05

VSharp.Explorer/AISearcher.fs

@@ -123,32 +123,28 @@ type internal AISearcher(oracle: Oracle, aiAgentTrainingMode: Option<AIAgentTrai
 
             Application.applicationGraphDelta.Clear()
 
-            if aiMode <> Runner && stepsToPlay = stepsPlayed then
+            let toPredict =
+                match aiMode with
+                | TrainingSendEachStep
+                | TrainingSendModel ->
+                    if stepsPlayed > 0u<step> then
+                        gameStateDelta
+                    else
+                        gameState.Value
+                | Runner -> gameState.Value
+
+            let stateId = oracle.Predict toPredict
+            afterFirstAIPeek <- true
+            let state = availableStates |> Seq.tryFind (fun s -> s.internalId = stateId)
+            lastCollectedStatistics <- statistics
+            stepsPlayed <- stepsPlayed + 1u<step>
+
+            match state with
+            | Some state -> Some state
+            | None ->
+                incorrectPredictedStateId <- true
+                oracle.Feedback(Feedback.IncorrectPredictedStateId stateId)
                 None
-            else
-                let toPredict =
-                    match aiMode with
-                    | TrainingSendEachStep
-                    | TrainingSendModel ->
-                        if stepsPlayed > 0u<step> then
-                            gameStateDelta
-                        else
-                            gameState.Value
-                    | Runner -> gameState.Value
-
-                let stateId = oracle.Predict toPredict
-
-                afterFirstAIPeek <- true
-                let state = availableStates |> Seq.tryFind (fun s -> s.internalId = stateId)
-                lastCollectedStatistics <- statistics
-                stepsPlayed <- stepsPlayed + 1u<step>
-
-                match state with
-                | Some state -> Some state
-                | None ->
-                    incorrectPredictedStateId <- true
-                    oracle.Feedback(Feedback.IncorrectPredictedStateId stateId)
-                    None
 
     static member updateGameState (delta: GameState) (gameState: Option<GameState>) =
         match gameState with

VSharp.ML.GameServer.Runner/Main.fs

@@ -239,6 +239,7 @@ let ws port outputDirectory (webSocket: WebSocket) (context: HttpContext) =
                             GameOver(
                                 explorationResult.ActualCoverage,
                                 explorationResult.TestsCount,
+                                explorationResult.StepsCount,
                                 explorationResult.ErrorsCount
                             )
                         )

VSharp.ML.GameServer/Messages.fs

@@ -109,11 +109,13 @@ type GameOverMessageBody =
     interface IRawOutgoingMessageBody
     val ActualCoverage: uint<percent>
     val TestsCount: uint32<test>
+    val StepsCount: uint32<step>
     val ErrorsCount: uint32<error>
 
-    new(actualCoverage, testsCount, errorsCount) =
+    new(actualCoverage, testsCount, stepsCount, errorsCount) =
         { ActualCoverage = actualCoverage
           TestsCount = testsCount
+          StepsCount = stepsCount
           ErrorsCount = errorsCount }
 
 [<Struct>]
@@ -371,7 +373,7 @@ type IncorrectPredictedStateIdMessageBody =
     new(stateId) = { StateId = stateId }
 
 type OutgoingMessage =
-    | GameOver of uint<percent> * uint32<test> * uint32<error>
+    | GameOver of uint<percent> * uint32<test> * uint32<step> * uint32<error>
     | MoveReward of Reward
     | IncorrectPredictedStateId of uint<stateId>
     | ReadyForNextStep of GameState
@@ -397,8 +399,8 @@ let deserializeInputMessage (messageData: byte[]) =
 
 let serializeOutgoingMessage (message: OutgoingMessage) =
     match message with
-    | GameOver(actualCoverage, testsCount, errorsCount) ->
-        RawOutgoingMessage("GameOver", box (GameOverMessageBody(actualCoverage, testsCount, errorsCount)))
+    | GameOver(actualCoverage, testsCount, stepsCount, errorsCount) ->
+        RawOutgoingMessage("GameOver", box (GameOverMessageBody(actualCoverage, testsCount, stepsCount, errorsCount)))
     | MoveReward reward -> RawOutgoingMessage("MoveReward", reward)
     | IncorrectPredictedStateId stateId ->
         RawOutgoingMessage("IncorrectPredictedStateId", IncorrectPredictedStateIdMessageBody stateId)