button priority

Author: NeloBlivion

discord/ui/action_row.py

@@ -91,6 +91,14 @@ def _add_component_from_item(self, item: Item):
 
     def _set_components(self, items: list[Item]):
         self._underlying.components.clear()
+        if not any(isinstance(b, Select) for b in self.children):
+            a, b = [], []
+            for i in items:
+                if i.priority is None:
+                    b.append(i)
+                else:
+                    a.append(i)
+            items = sorted(a, key=lambda b: b.priority) + b
         for item in items:
             self._add_component_from_item(item)
 
@@ -108,8 +116,12 @@ def add_item(self, item: Item) -> Self:
             An :class:`Item` was not passed.
         """
 
-        if not isinstance(item, Item):
-            raise TypeError(f"expected Item not {item.__class__!r}")
+        if not isinstance(item, (Select, Button)):
+            raise TypeError(f"expected Select or Button, not {item.__class__!r}")
+        if item.row:
+            raise ValueError(f"{item.__class__!r}.row is not supported in ActionRow")
+        if self.width + item.width > 5:
+            raise ValueError(f"Not enough space left on this ActionRow")
 
         item._view = self.view
         item.parent = self
@@ -166,6 +178,7 @@ def add_button(
         emoji: str | GuildEmoji | AppEmoji | PartialEmoji | None = None,
         sku_id: int | None = None,
         id: int | None = None,
+        priority: int | None = None
     ) -> Self:
         """Adds a :class:`Button` to the action row.
 
@@ -191,6 +204,10 @@ def add_button(
             The ID of the SKU this button refers to.
         id: Optional[:class:`int`]
             The button's ID.
+        priority: Optional[:class:`int`]
+            An integer greater than 0. If specified, decides the position
+            of the button in this row instead of going by order of addition. The lower this number, the earlier its position.
+            This ActionRow's children will be reordered when the View containing it is sent. A priority of ``None`` will be ordered after any specified priority.
         """
 
         button = Button(
@@ -202,6 +219,7 @@ def add_button(
             emoji=emoji,
             sku_id=sku_id,
             id=id,
+            priority=priority
         )
 
         return self.add_item(button)
@@ -320,6 +338,14 @@ def enable_all_items(self, *, exclusions: list[Item] | None = None) -> Self:
                 item.disabled = False
         return self
 
+    @property
+    def width(self):
+        """Return the sum of the items' widths."""
+        t = 0
+        for item in self.children:
+            t += 1 if item._underlying.type is ComponentType.button else 5
+        return t
+
     def walk_items(self) -> Iterator[Item]:
         yield from self.children
 

discord/ui/button.py

@@ -78,10 +78,14 @@ class Button(Item[V]):
 
         .. warning::
 
-            This parameter does not work with V2 components or with more than 25 items in your view.
+            This parameter does not work in :class:`ActionRow`.
 
     id: Optional[:class:`int`]
         The button's ID.
+    priority: Optional[:class:`int`]
+        Only works in :class:`ActionRow`. Any integer greater than 0. If specified, decides the position
+        of the button in this row instead of going by order of addition. The lower this number, the earlier its position.
+        The ActionRow's children will be reordered when the View containing this button is sent.
     """
 
     __item_repr_attributes__: tuple[str, ...] = (
@@ -94,6 +98,7 @@ class Button(Item[V]):
         "row",
         "custom_id",
         "id",
+        "priority",
     )
 
     def __init__(
@@ -108,6 +113,7 @@ def __init__(
         sku_id: int | None = None,
         row: int | None = None,
         id: int | None = None,
+        priority: int | None = None,
     ):
         super().__init__()
         if label and len(str(label)) > 80:
@@ -120,11 +126,14 @@ def __init__(
             raise TypeError("cannot mix both url and sku_id with Button")
         if custom_id is not None and sku_id is not None:
             raise TypeError("cannot mix both sku_id and custom_id with Button")
+        if priority and (priority < 0 or not isinstance(priority, int)):
+            raise ValueError("priority must be an integer greater than 0")
 
         if not isinstance(custom_id, str) and custom_id is not None:
             raise TypeError(
                 f"expected custom_id to be str, not {custom_id.__class__.__name__}"
             )
+        self.priority: int | None = priority
 
         self._provided_custom_id = custom_id is not None
         if url is None and custom_id is None and sku_id is None:
@@ -294,6 +303,7 @@ def button(
     emoji: str | GuildEmoji | AppEmoji | PartialEmoji | None = None,
     row: int | None = None,
     id: int | None = None,
+    priority: int | None = None,
 ) -> Callable[[ItemCallbackType[Button[V]]], Button[V]]:
     """A decorator that attaches a button to a component.
 
@@ -328,6 +338,15 @@ def button(
         like to control the relative positioning of the row then passing an index is advised.
         For example, row=1 will show up before row=2. Defaults to ``None``, which is automatic
         ordering. The row number must be between 0 and 4 (i.e. zero indexed).
+
+        .. warning::
+
+            This parameter does not work in :class:`ActionRow`.
+
+    priority: Optional[:class:`int`]
+        Only works in :class:`ActionRow`. Any integer greater than 0. If specified, decides the position
+        of the button in this row instead of going by order of addition. The lower this number, the earlier its position.
+        The ActionRow's children will be reordered when the View containing it is sent. A priority of ``None`` will be ordered after any specified priority.
     """
 
     def decorator(func: ItemCallbackType) -> ItemCallbackType:
@@ -344,6 +363,7 @@ def decorator(func: ItemCallbackType) -> ItemCallbackType:
             "emoji": emoji,
             "row": row,
             "id": id,
+            "priority": priority
         }
         return func
 

discord/ui/container.py

@@ -65,6 +65,12 @@ class Container(Item[V]):
         "id",
     )
 
+    def __init_subclass__(cls) -> None:
+        for base in reversed(cls.__mro__):
+            for member in base.__dict__.values():
+                if hasattr(member, "__discord_ui_model_type__"):
+                    raise ValueError("The @button and @select decorators are incompatible with Container. Use ActionRow instead.")
+
     def __init__(
         self,
         *items: Item,

discord/ui/view.py

@@ -782,6 +782,12 @@ class DesignerView(BaseView):
 
     MAX_ITEMS: int = 40
 
+    def __init_subclass__(cls) -> None:
+        for base in reversed(cls.__mro__):
+            for member in base.__dict__.values():
+                if hasattr(member, "__discord_ui_model_type__"):
+                    raise ValueError("The @button and @select decorators are incompatible with DesignerView. Use ActionRow instead.")
+
     def __init__(
         self,
         *items: Item[V],