Merge branch 'master' into appinf

Author: Lumabots

.pre-commit-config.yaml

@@ -31,7 +31,7 @@ repos:
       - id: isort
         exclude: \.(po|pot|yml|yaml)$
   - repo: https://github.com/psf/black-pre-commit-mirror
-    rev: 25.11.0
+    rev: 25.12.0
     hooks:
       - id: black
         args: [--safe, --quiet]

CHANGELOG.md

@@ -24,6 +24,9 @@ These changes are available on the `master` branch, but have not yet been releas
 
 ### Fixed
 
+- Fixed `TypeError` in paginator implementation when only passing `PageGroup` objects
+  and `show_menu` is falsy.
+  ([#2993](https://github.com/Pycord-Development/pycord/pull/2993))
 - Fixed breaking change in `ui.Select` Generic typing by adding default values to
   TypeVars. ([#3002](https://github.com/Pycord-Development/pycord/pull/3002))
 

discord/ext/pages/pagination.py

@@ -418,17 +418,20 @@ def __init__(
         self.default_page_group: int = 0
 
         if all(isinstance(pg, PageGroup) for pg in pages):
-            self.page_groups = self.pages if show_menu else None
-            if sum(pg.default is True for pg in self.page_groups) > 1:
+            if sum(pg.default is True for pg in pages) > 1:
                 raise ValueError("Only one PageGroup can be set as the default.")
-            for pg in self.page_groups:
+
+            default_pg_index = 0
+            for pg in pages:
                 if pg.default:
-                    self.default_page_group = self.page_groups.index(pg)
+                    default_pg_index = pages.index(pg)
                     break
+
             self.pages: list[Page] = self.get_page_group_content(
-                self.page_groups[self.default_page_group]
+                pages[default_pg_index]
             )
 
+            self.page_groups = self.pages if show_menu else None
         self.page_count = max(len(self.pages) - 1, 0)
         self.buttons = {}
         self.custom_buttons: list = custom_buttons
@@ -530,16 +533,20 @@ async def update(
         ) = (pages if pages is not None else self.pages)
         self.show_menu = show_menu if show_menu is not None else self.show_menu
         if pages is not None and all(isinstance(pg, PageGroup) for pg in pages):
-            self.page_groups = self.pages if self.show_menu else None
-            if sum(pg.default is True for pg in self.page_groups) > 1:
+            if sum(pg.default is True for pg in pages) > 1:
                 raise ValueError("Only one PageGroup can be set as the default.")
-            for pg in self.page_groups:
+
+            default_pg_index = 0
+            for pg in pages:
                 if pg.default:
-                    self.default_page_group = self.page_groups.index(pg)
+                    default_pg_index = pages.index(pg)
                     break
+
             self.pages: list[Page] = self.get_page_group_content(
-                self.page_groups[self.default_page_group]
+                pages[default_pg_index]
             )
+
+            self.page_groups = self.pages if show_menu else None
         self.page_count = max(len(self.pages) - 1, 0)
         self.current_page = current_page if current_page <= self.page_count else 0
         # Apply config changes, if specified

discord/message.py

@@ -314,7 +314,7 @@ async def save(
             deleted attachments if too much time has passed, and it does not work
             on some types of attachments.
         chunksize: Optional[:class:`int`]
-            The maximum size of each chunk to process.
+            The maximum size of each chunk to process. Must be a positive integer.
 
         Returns
         -------
@@ -336,7 +336,7 @@ async def save(
             data = await self.read(use_cached=use_cached)
 
         if isinstance(fp, io.BufferedIOBase):
-            if chunksize:
+            if chunksize is not None:
                 written = 0
                 async for chunk in data:
                     written += fp.write(chunk)
@@ -347,7 +347,7 @@ async def save(
             return written
         else:
             with open(fp, "wb") as f:
-                if chunksize:
+                if chunksize is not None:
                     written = 0
                     async for chunk in data:
                         written += f.write(chunk)
@@ -400,7 +400,7 @@ async def read_chunked(
         Parameters
         ----------
         chunksize: :class:`int`
-            The maximum size of each chunk to process.
+            The maximum size of each chunk to process. Must be a positive integer.
         use_cached: :class:`bool`
             Whether to use :attr:`proxy_url` rather than :attr:`url` when downloading
             the attachment. This will allow attachments to be saved after deletion