fix: 🐛 Fix docs rendering for ForwardedMessage and MessageSnapshot and add missing attributes (#3051)

* 📝 Add missing rendering for MessageSnapshot in docs

* 📝 Add missing rendering for ForwardedMessage in docs

* 🐛 Add missing mentions property for ForwardedMessage

* style(pre-commit): auto fixes from pre-commit.com hooks

* Add to changelog

* style(pre-commit): auto fixes from pre-commit.com hooks

* Correct data conversion

* Correct docstring data type

* 📝 Add note in docs to inform about empty list possibility

* 📝 Update role_mentions docs to warn about its usage

* Implement type attribute

* Update changelog accordingly

* Copy role mentions logic from `Message`

This knowingly doesn't work yet due to a Discord limitation / unresolved discussion on the API. A warning in the docs is in place

* Add missing type information

* Update changelog

* Update CHANGELOG.md

,

Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com>

---------

Signed-off-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>

Author: 3 people

CHANGELOG.md

@@ -30,6 +30,9 @@ These changes are available on the `master` branch, but have not yet been releas
 - Fixed `Interaction.channel` not being resolved with user-installed commands ran in
   guilds which the bot is not a member of.
   ([#3047](https://github.com/Pycord-Development/pycord/pull/3047))
+- Fixed the `ForwardedMessage.mentions`, `ForwardedMessage.role_mentions`, and
+  `ForwardedMessage.type` attributes not being populated.
+  ([#3051](https://github.com/Pycord-Development/pycord/pull/3051))
 
 - Fixed incorrect page group assignment in `Paginator`.
   ([#3065](https://github.com/Pycord-Development/pycord/pull/3065))

discord/message.py

@@ -107,6 +107,7 @@
     "MessageCall",
     "DeletedReferencedMessage",
     "ForwardedMessage",
+    "MessageSnapshot",
 )
 
 
@@ -747,10 +748,17 @@ class ForwardedMessage:
         A list of attachments given to the original message.
     flags: :class:`MessageFlags`
         Extra features of the original message.
-    mentions: List[Union[:class:`abc.User`, :class:`Object`]]
-        A list of :class:`Member` that were originally mentioned.
-    role_mentions: List[Union[:class:`Role`, :class:`Object`]]
+    mentions: List[:class:`User`]
+        A list of :class:`User` that were originally mentioned.
+
+        .. note::
+            This list will be empty if the message was forwarded to a different place, e.g., from a DM to a guild, or
+            from one guild to another.
+    role_mentions: List[:class:`Role`]
         A list of :class:`Role` that were originally mentioned.
+
+        .. warning::
+            This is only available using :meth:`abc.Messageable.fetch_message`.
     stickers: List[:class:`StickerItem`]
         A list of sticker items given to the original message.
     components: List[:class:`Component`]
@@ -792,6 +800,17 @@ def __init__(
         self.components: list[Component] = [
             _component_factory(d) for d in data.get("components", [])
         ]
+        self.mentions: list[User] = [
+            state.create_user(data=user) for user in data["mentions"]
+        ]
+        self.role_mentions: list[Role] = []
+        if isinstance(self.guild, Guild) and data.get("mention_roles"):
+            for role_id in map(int, data["mention_roles"]):
+                role = self.guild.get_role(role_id)
+                if role is not None:
+                    self.role_mentions.append(role)
+
+        self.type: MessageType = try_enum(MessageType, data["type"])
         self._edited_timestamp: datetime.datetime | None = utils.parse_time(
             data["edited_timestamp"]
         )
@@ -1023,7 +1042,7 @@ class Message(Hashable):
         The call information associated with this message, if applicable.
 
         .. versionadded:: 2.6
-    snapshots: Optional[List[:class:`MessageSnapshots`]]
+    snapshots: Optional[List[:class:`MessageSnapshot`]]
         The snapshots attached to this message, if applicable.
 
         .. versionadded:: 2.7

docs/api/models.rst

@@ -89,6 +89,16 @@ Messages
 .. autoclass:: Message()
     :members:
 
+.. attributetable:: MessageSnapshot
+
+.. autoclass:: MessageSnapshot()
+    :members:
+
+.. attributetable:: ForwardedMessage
+
+.. autoclass:: ForwardedMessage()
+    :members:
+
 .. attributetable:: DeletedReferencedMessage
 
 .. autoclass:: DeletedReferencedMessage()