refactor: Add missing with_counts parameter to guild retrieval methods

Author: BruhDark

discord/client.py

@@ -1462,6 +1462,7 @@ def fetch_guilds(
         limit: int | None = 100,
         before: SnowflakeTime = None,
         after: SnowflakeTime = None,
+        with_counts: bool = False,
     ) -> GuildIterator:
         """Retrieves an :class:`.AsyncIterator` that enables receiving your guilds.
 
@@ -1489,6 +1490,10 @@ def fetch_guilds(
             Retrieve guilds after this date or object.
             If a datetime is provided, it is recommended to use a UTC aware datetime.
             If the datetime is naive, it is assumed to be local time.
+        with_counts: Optional[:class:`bool`]
+            Whether to include count information in the guilds. This fills the
+            :attr:`.Guild.approximate_member_count` and :attr:`.Guild.approximate_presence_count`
+            fields.
 
         Yields
         ------
@@ -1835,8 +1840,8 @@ async def fetch_user(self, user_id: int, /) -> User:
         return User(state=self._connection, data=data)
 
     async def fetch_channel(
-        self, channel_id: int, /
-    ) -> GuildChannel | PrivateChannel | Thread:
+            self, channel_id: int,
+            /) -> GuildChannel | PrivateChannel | Thread:
         """|coro|
 
         Retrieves a :class:`.abc.GuildChannel`, :class:`.abc.PrivateChannel`, or :class:`.Thread` with the specified ID.

discord/http.py

@@ -1445,6 +1445,7 @@ def get_guilds(
         limit: int,
         before: Snowflake | None = None,
         after: Snowflake | None = None,
+        with_counts: bool = False,
     ) -> Response[list[guild.Guild]]:
         params: dict[str, Any] = {
             "limit": limit,
@@ -1454,6 +1455,8 @@ def get_guilds(
             params["before"] = before
         if after:
             params["after"] = after
+        if with_counts:
+            params["with_counts"] = with_counts
 
         return self.request(Route("GET", "/users/@me/guilds"), params=params)
 
@@ -3135,8 +3138,8 @@ def application_info(self) -> Response[appinfo.AppInfo]:
         return self.request(Route("GET", "/oauth2/applications/@me"))
 
     def get_application(
-        self, application_id: Snowflake, /
-    ) -> Response[appinfo.PartialAppInfo]:
+            self, application_id: Snowflake,
+            /) -> Response[appinfo.PartialAppInfo]:
         return self.request(
             Route(
                 "GET",

discord/iterators.py

@@ -587,7 +587,7 @@ class GuildIterator(_AsyncIterator["Guild"]):
         Object after which all guilds must be.
     """
 
-    def __init__(self, bot, limit, before=None, after=None):
+    def __init__(self, bot, limit, before=None, after=None, with_counts=False):
         if isinstance(before, datetime.datetime):
             before = Object(id=time_snowflake(before, high=False))
         if isinstance(after, datetime.datetime):
@@ -597,6 +597,7 @@ def __init__(self, bot, limit, before=None, after=None):
         self.limit = limit
         self.before = before
         self.after = after
+        self.with_counts = with_counts
 
         self._filter = None
 
@@ -654,7 +655,7 @@ async def _retrieve_guilds(self, retrieve) -> list[Guild]:
     async def _retrieve_guilds_before_strategy(self, retrieve):
         """Retrieve guilds using before parameter."""
         before = self.before.id if self.before else None
-        data: list[GuildPayload] = await self.get_guilds(retrieve, before=before)
+        data: list[GuildPayload] = await self.get_guilds(retrieve, before=before, with_counts=self.with_counts)
         if len(data):
             if self.limit is not None:
                 self.limit -= retrieve
@@ -664,7 +665,7 @@ async def _retrieve_guilds_before_strategy(self, retrieve):
     async def _retrieve_guilds_after_strategy(self, retrieve):
         """Retrieve guilds using after parameter."""
         after = self.after.id if self.after else None
-        data: list[GuildPayload] = await self.get_guilds(retrieve, after=after)
+        data: list[GuildPayload] = await self.get_guilds(retrieve, after=after, with_counts=self.with_counts)
         if len(data):
             if self.limit is not None:
                 self.limit -= retrieve