update refresh logic

Author: NeloBlivion

discord/ui/input_text.py

@@ -238,7 +238,7 @@ def to_component_dict(self) -> InputTextComponentPayload:
     def refresh_state(self, data) -> None:
         self._input_value = data["value"]
 
-    def refresh_from_modal(self, interaction: Interaction, data: dict) -> None:
+    def refresh_from_modal(self, interaction: Interaction, data: InputTextComponentPayload) -> None:
         return self.refresh_state(data)
 
 

discord/ui/label.py

@@ -270,6 +270,9 @@ def to_component_dict(self) -> LabelPayload:
         self._set_component_from_item(self.item)
         return self._underlying.to_dict()
 
+    def refresh_from_modal(self, interaction: Interaction, data: LabelPayload) -> None:
+        return self.item.refresh_from_modal(interaction, data.get("component", {}))
+
     @classmethod
     def from_component(cls: type[L], component: LabelComponent) -> L:
         from .view import _component_to_item

discord/ui/modal.py

@@ -30,6 +30,7 @@
 
     from ..interactions import Interaction
     from ..state import ConnectionState
+    from ..types.components import Component as ComponentPayload
 
 M = TypeVar("M", bound="Modal", covariant=True)
 
@@ -343,6 +344,18 @@ def remove_item(self, item: InputText) -> Self:
             pass
         return self
 
+    def refresh(self, interaction: Interaction, data: list[ComponentPayload]):
+        components = [
+            component
+            for parent_component in data
+            for component in parent_component["components"]
+        ]
+        for component in components:
+            for child in self.children:
+                if child.custom_id == component["custom_id"]:  # type: ignore
+                    child.refresh_from_modal(interaction, component)
+                    break
+
 
 class DesignerModal(BaseModal):
     """Represents a UI modal compatible with all modal features.
@@ -406,6 +419,10 @@ def add_item(self, item: ModalItem) -> Self:
         super().add_item(item)
         return self
 
+    def refresh(self, interaction: Interaction, data: list[ComponentPayload]):
+        for component, child in zip(data, self.children):
+            child.refresh_from_modal(interaction, component)
+
 
 class _ModalWeights:
     __slots__ = ("weights",)
@@ -465,27 +482,15 @@ def remove_modal(self, modal: BaseModal, user_id):
 
     async def dispatch(self, user_id: int, custom_id: str, interaction: Interaction):
         key = (user_id, custom_id)
-        value = self._modals.get(key)
+        modal = self._modals.get(key)
         if value is None:
             return
-        interaction.modal = value
+        interaction.modal = modal
 
         try:
-            components = [
-                component
-                for parent_component in interaction.data["components"]
-                for component in (
-                    parent_component.get("components")
-                    or (
-                        [parent_component.get("component")]
-                        if parent_component.get("component")
-                        else [parent_component]
-                    )
-                )
-            ]
-            for component, child in zip(components, value.children):
-                child.refresh_from_modal(interaction, component)
-            await value.callback(interaction)
-            self.remove_modal(value, user_id)
+            components = interaction.data["components"]
+            modal.refresh(interaction, components)
+            await modal.callback(interaction)
+            self.remove_modal(modal, user_id)
         except Exception as e:
-            return await value.on_error(e, interaction)
+            return await modal.on_error(e, interaction)

discord/ui/select.py

@@ -724,7 +724,7 @@ def refresh_state(self, interaction: Interaction | dict) -> None:
         self._selected_values = data.get("values", [])
         self._interaction = interaction
 
-    def refresh_from_modal(self, interaction: Interaction | dict, data: dict) -> None:
+    def refresh_from_modal(self, interaction: Interaction | dict, data: SelectMenuPayload) -> None:
         self._selected_values = data.get("values", [])
         self._interaction = interaction
 

discord/ui/view.py

@@ -737,6 +737,12 @@ def refresh(self, components: list[Component]):
         self.children = children
 
     def is_components_v2(self) -> bool:
+        """Whether the view contains V2 components.
+
+        A view containing V2 components cannot be sent alongside message content or embeds.
+
+        This is always ``False`` for :class:`View`.
+        """
         return False
 
 
@@ -883,13 +889,7 @@ def refresh(self, components: list[Component]):
                 i += 1
 
     def is_components_v2(self) -> bool:
-        """Whether the view contains V2 components or requires the V2 flag.
-
-        A view containing V2 components cannot be sent alongside message content or embeds.
-        """
-        return len(self.children) > 5 or any(
-            i.is_components_v2() for i in self.children
-        )
+        return len(self.children) > 5 or super().is_components_v2()
 
 
 class ViewStore: