Skip to content

Commit eaa3d77

Browse files
committed
use utils._get_as_snowflake and remove old code
1 parent 109a06c commit eaa3d77

File tree

1 file changed

+27
-90
lines changed

1 file changed

+27
-90
lines changed

discord/raw_models.py

Lines changed: 27 additions & 90 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,7 @@ def __init__(self, data: MessageDeleteEvent) -> None:
127127
self.message_id: int = int(data["id"])
128128
self.channel_id: int = int(data["channel_id"])
129129
self.cached_message: Message | None = None
130-
try:
131-
self.guild_id: int | None = int(data["guild_id"])
132-
except KeyError:
133-
self.guild_id: int | None = None
130+
self.guild_id: int | None = utils._get_as_snowflake(data, 'guild_id')
134131
self.data: MessageDeleteEvent = data
135132

136133

@@ -159,11 +156,7 @@ def __init__(self, data: BulkMessageDeleteEvent) -> None:
159156
self.message_ids: set[int] = {int(x) for x in data.get("ids", [])}
160157
self.channel_id: int = int(data["channel_id"])
161158
self.cached_messages: list[Message] = []
162-
163-
try:
164-
self.guild_id: int | None = int(data["guild_id"])
165-
except KeyError:
166-
self.guild_id: int | None = None
159+
self.guild_id: int | None = utils._get_as_snowflake(data, 'guild_id')
167160
self.data: BulkMessageDeleteEvent = data
168161

169162

@@ -197,11 +190,7 @@ def __init__(self, data: MessageUpdateEvent) -> None:
197190
self.channel_id: int = int(data["channel_id"])
198191
self.data: MessageUpdateEvent = data
199192
self.cached_message: Message | None = None
200-
201-
try:
202-
self.guild_id: int | None = int(data["guild_id"])
203-
except KeyError:
204-
self.guild_id: int | None = None
193+
self.guild_id: int | None = utils._get_as_snowflake(data, 'guild_id')
205194

206195

207196
class RawReactionActionEvent(_RawReprMixin):
@@ -274,11 +263,7 @@ def __init__(
274263
self.burst_colours: list = data.get("burst_colors", [])
275264
self.burst_colors: list = self.burst_colours
276265
self.type: ReactionType = try_enum(ReactionType, data.get("type", 0))
277-
278-
try:
279-
self.guild_id: int | None = int(data["guild_id"])
280-
except KeyError:
281-
self.guild_id: int | None = None
266+
self.guild_id: int | None = utils._get_as_snowflake(data, 'guild_id')
282267
self.data: ReactionActionEvent = data
283268

284269

@@ -304,11 +289,7 @@ class RawReactionClearEvent(_RawReprMixin):
304289
def __init__(self, data: ReactionClearEvent) -> None:
305290
self.message_id: int = int(data["message_id"])
306291
self.channel_id: int = int(data["channel_id"])
307-
308-
try:
309-
self.guild_id: int | None = int(data["guild_id"])
310-
except KeyError:
311-
self.guild_id: int | None = None
292+
self.guild_id: int | None = utils._get_as_snowflake(data, 'guild_id')
312293
self.data: ReactionClearEvent = data
313294

314295

@@ -361,11 +342,7 @@ def __init__(self, data: ReactionClearEmojiEvent, emoji: PartialEmoji) -> None:
361342
self.burst_colours: list = data.get("burst_colors", [])
362343
self.burst_colors: list = self.burst_colours
363344
self.type: ReactionType = try_enum(ReactionType, data.get("type", 0))
364-
365-
try:
366-
self.guild_id: int | None = int(data["guild_id"])
367-
except KeyError:
368-
self.guild_id: int | None = None
345+
self.guild_id: int | None = utils._get_as_snowflake(data, 'guild_id')
369346
self.data: ReactionClearEmojiEvent = data
370347

371348

@@ -393,11 +370,7 @@ class RawIntegrationDeleteEvent(_RawReprMixin):
393370
def __init__(self, data: IntegrationDeleteEvent) -> None:
394371
self.integration_id: int = int(data["id"])
395372
self.guild_id: int = int(data["guild_id"])
396-
397-
try:
398-
self.application_id: int | None = int(data["application_id"])
399-
except KeyError:
400-
self.application_id: int | None = None
373+
self.application_id: int | None = utils._get_as_snowflake(data, 'application_id')
401374
self.data: IntegrationDeleteEvent = data
402375

403376

@@ -460,10 +433,10 @@ class RawThreadDeleteEvent(_RawReprMixin):
460433
__slots__ = ("thread_id", "thread_type", "guild_id", "parent_id", "thread", "data")
461434

462435
def __init__(self, data: ThreadDeleteEvent) -> None:
463-
self.thread_id: int = int(data["id"])
464-
self.thread_type: ChannelType = try_enum(ChannelType, int(data["type"]))
465-
self.guild_id: int = int(data["guild_id"])
466-
self.parent_id: int = int(data["parent_id"])
436+
self.thread_id: int = int(data["id"]) # type: ignore
437+
self.thread_type: ChannelType = try_enum(ChannelType, int(data["type"])) # type: ignore
438+
self.guild_id: int = int(data["guild_id"]) # type: ignore
439+
self.parent_id: int = int(data["parent_id"]) # type: ignore
467440
self.thread: Thread | None = None
468441
self.data: ThreadDeleteEvent = data
469442

@@ -490,11 +463,7 @@ class RawVoiceChannelStatusUpdateEvent(_RawReprMixin):
490463
def __init__(self, data: VoiceChannelStatusUpdateEvent) -> None:
491464
self.id: int = int(data["id"])
492465
self.guild_id: int = int(data["guild_id"])
493-
494-
try:
495-
self.status: str | None = data["status"]
496-
except KeyError:
497-
self.status: str | None = None
466+
self.status: str | None = data.get('status')
498467
self.data: VoiceChannelStatusUpdateEvent = data
499468

500469

@@ -530,11 +499,7 @@ def __init__(self, data: TypingEvent) -> None:
530499
data.get("timestamp"), tz=datetime.timezone.utc
531500
)
532501
self.member: Member | None = None
533-
534-
try:
535-
self.guild_id: int | None = int(data["guild_id"])
536-
except KeyError:
537-
self.guild_id: int | None = None
502+
self.guild_id: int | None = utils._get_as_snowflake(data, 'guild_id')
538503
self.data: TypingEvent = data
539504

540505

@@ -589,8 +554,8 @@ class RawScheduledEventSubscription(_RawReprMixin):
589554
__slots__ = ("event_id", "guild", "user_id", "event_type", "data")
590555

591556
def __init__(self, data: ScheduledEventSubscription, event_type: str):
592-
self.event_id: int = int(data["guild_scheduled_event_id"])
593-
self.user_id: int = int(data["user_id"])
557+
self.event_id: int = int(data["guild_scheduled_event_id"]) # type: ignore
558+
self.user_id: int = int(data["user_id"]) # type: ignore
594559
self.guild: Guild | None = None
595560
self.event_type: str = event_type
596561
self.data: ScheduledEventSubscription = data
@@ -676,42 +641,18 @@ def __init__(self, state: ConnectionState, data: AutoModActionExecution) -> None
676641
self.guild: Guild | None = state._get_guild(self.guild_id)
677642
self.user_id: int = int(data["user_id"])
678643
self.content: str | None = data.get("content", None)
679-
self.matched_keyword: str = data["matched_keyword"]
644+
self.matched_keyword: str = data["matched_keyword"] # type: ignore
680645
self.matched_content: str | None = data.get("matched_content", None)
681-
682-
if self.guild:
683-
self.member: Member | None = self.guild.get_member(self.user_id)
684-
else:
685-
self.member: Member | None = None
686-
687-
try:
688-
# I don't see why this would be optional, but it's documented
689-
# as such, so we should treat it that way
690-
self.channel_id: int | None = int(data["channel_id"])
691-
self.channel: MessageableChannel | None = self.guild.get_channel_or_thread(
692-
self.channel_id
693-
)
694-
except KeyError:
695-
self.channel_id: int | None = None
696-
self.channel: MessageableChannel | None = None
697-
698-
try:
699-
self.message_id: int | None = int(data["message_id"])
700-
self.message: Message | None = state._get_message(self.message_id)
701-
except KeyError:
702-
self.message_id: int | None = None
703-
self.message: Message | None = None
704-
705-
try:
706-
self.alert_system_message_id: int | None = int(
707-
data["alert_system_message_id"]
708-
)
709-
self.alert_system_message: Message | None = state._get_message(
710-
self.alert_system_message_id
711-
)
712-
except KeyError:
713-
self.alert_system_message_id: int | None = None
714-
self.alert_system_message: Message | None = None
646+
self.channel_id: int | None = utils._get_as_snowflake(data, 'channel_id')
647+
self.channel: MessageableChannel | None = (
648+
self.channel_id and self.guild
649+
and self.guild.get_channel_or_thread(self.channel_id)
650+
) # type: ignore
651+
self.member: Member | None = self.guild and self.guild.get_member(self.user_id)
652+
self.message_id: int | None = utils._get_as_snowflake(data, 'message_id')
653+
self.message: Message | None = state._get_message(self.message_id)
654+
self.alert_system_message_id: int | None = utils._get_as_snowflake(data, 'alert_system_message_id')
655+
self.alert_system_message: Message | None = state._get_message(self.alert_system_message_id)
715656
self.data: AutoModActionExecution = data
716657

717658
def __repr__(self) -> str:
@@ -848,11 +789,7 @@ def __init__(self, data: MessagePollVoteEvent, added: bool) -> None:
848789
self.answer_id: int = int(data["answer_id"])
849790
self.data: MessagePollVoteEvent = data
850791
self.added: bool = added
851-
852-
try:
853-
self.guild_id: int | None = int(data["guild_id"])
854-
except KeyError:
855-
self.guild_id: int | None = None
792+
self.guild_id: int | None = utils._get_as_snowflake(data, 'guild_id')
856793

857794

858795
# this is for backwards compatibility because VoiceProtocol.on_voice_..._update

0 commit comments

Comments
 (0)