Skip to content

Commit ec5da54

Browse files
authored
fix(state): ensure _messages is not None before updating message list (#2924)
* fix(state): ensure _messages is not None before updating message list * chore: update changelog
1 parent 907931d commit ec5da54

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ These changes are available on the `master` branch, but have not yet been releas
3333
([#2915](https://github.com/Pycord-Development/pycord/pull/2915))
3434
- `View.message` being `None` when it had not been interacted with yet.
3535
([#2916](https://github.com/Pycord-Development/pycord/pull/2916))
36+
- Fixed a crash when processing message edit events while message cache was disabled.
37+
([#2924](https://github.com/Pycord-Development/pycord/pull/2924))
3638

3739
### Removed
3840

discord/state.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -779,9 +779,10 @@ def parse_message_update(self, data) -> None:
779779
old_message = self._get_message(int(data["id"]))
780780
channel, _ = self._get_guild_channel(data)
781781
message = Message(channel=channel, data=data, state=self)
782-
if old_message is not None:
783-
self._messages.remove(old_message)
784-
self._messages.append(message)
782+
if self._messages is not None:
783+
if old_message is not None:
784+
self._messages.remove(old_message)
785+
self._messages.append(message)
785786
raw = RawMessageUpdateEvent(data, message)
786787
self.dispatch("raw_message_edit", raw)
787788
if old_message is not None:

0 commit comments

Comments
 (0)