Skip to content

fix: 🐛 Handle python 3.12+ TypeAliasType in Option parsing #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2025
Merged

fix: 🐛 Handle python 3.12+ TypeAliasType in Option parsing #2952

merged 3 commits into from
Oct 20, 2025

Conversation

Paillat-dev
Copy link
Member

@Paillat-dev Paillat-dev commented Oct 12, 2025 •
edited
Loading

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev requested a review from a team as a code owner October 12, 2025 21:10
@pycord-app
Copy link

pycord-app bot commented Oct 12, 2025

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/2952/head:pr-2952
git checkout pr-2952

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2952/head

@Paillat-dev Paillat-dev requested a review from Lumabots October 12, 2025 21:11
@Paillat-dev Paillat-dev requested review from a team as code owners October 12, 2025 21:14
@Paillat-dev Paillat-dev linked an issue Oct 12, 2025 that may be closed by this pull request
Python 3.12+ type keyword not supported in command types #2951
Closed
3 tasks
Soheab
Soheab previously approved these changes Oct 12, 2025
View reviewed changes
Copy link
Contributor

@Soheab Soheab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested code in the issue.

@Soheab

This comment has been minimized.

Sign in to view
@Soheab Soheab added the on hold label Oct 17, 2025
Lumabots
Lumabots approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@Lumabots Lumabots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works it works
cant wait for option rewrite tho

@Soheab Soheab removed the on hold label Oct 20, 2025
@Lulalaby Lulalaby merged commit 72b6e05 into master Oct 20, 2025
28 checks passed
@Lulalaby Lulalaby deleted the fix/type-alias-cmd-options branch October 20, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Lumabots Lumabots Lumabots approved these changes

@Soheab Soheab Soheab left review comments

@NeloBlivion NeloBlivion Awaiting requested review from NeloBlivion NeloBlivion is a code owner automatically assigned from Pycord-Development/library-maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python 3.12+ type keyword not supported in command types

4 participants

@Paillat-dev @Soheab @Lulalaby @Lumabots