[Bug report] Something fishy with recent APR changes and the extra APR Quest Reward (new thresholds incorrect?)

[Silver-D]

This is my first time playing this game ever so I'm not exactly familiar with the game's intended mechanics.
Few days ago I was in the middle of a playthrough when the new APR changes got released and my hero's APR got fixed to match the tooltips for his appropriate level (yay, thanks!).

However, I just finished Selena's second extra quest and something really doesn't seem right when she gains an extra APR. The APR level thresholds change and go haywire. I'm attaching a screenshot before and after she gets the buff. (And also how I was able to fix? it in the source for myself)

Also, as soon as she levels up after getting the buff, she even gets another APR even though she is not at the threshold for the next APR -- for a total of 5 at level 37. This shouldn't be possible according to the original tooltip?
I may be missing something as I'm not familiar with this game. Forgive if I'm misunderstanding, or if the tooltips are incorrect, etc.

Additional context
I'm building from source so here is my version of the fix for my save game. Not sure if this is the correct fix, but I fixed it for myself because I can't play with 5 APR when I think shouldn't have it :(

In Game.cs in the case RewardEvent.RewardType.AttacksPerRound: block we are determining var currentAttacksPerRoundIncreaseLevels = using the partyMember.AttacksPerRound -- AFTER it has already been increased by rewardEvent.Value. So I changed

partyMember.AttacksPerRound to oldAttacksPerRound, which is the saved value calculated from the original APR before partyMember.AttacksPerRound is increased by rewardEvent.Value.

from:

if (partyMember.AttacksPerRound != oldAttacksPerRound)
{
    var currentAttacksPerRoundIncreaseLevels = partyMember.Level / Math.Max(1, (int)partyMember.AttacksPerRound);
// ...
}

to:

if (partyMember.AttacksPerRound != oldAttacksPerRound)
{
    var currentAttacksPerRoundIncreaseLevels = partyMember.Level / Math.Max(1, oldAttacksPerRound);
// ...
}

Desktop (please complete the following information):

• OS: Linux (Fedora 42)
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

[Pyrdacor]

Sorry that it took me so long to respond. I finally had some time to look into this. I think your fix is still not 100% correct. It will work if APR is increased by 1 (which is usually the case). But to make it work in all cases the right formula is:

var currentAttacksPerRoundIncreaseLevels = partyMember.Level / Math.Max(1, (int)partyMember.AttacksPerRound - 1);

You see that it matches your fix if partyMember.AttacksPerRound = oldAttacksPerRound + 1. Because then it becomes:

var currentAttacksPerRoundIncreaseLevels = partyMember.Level / Math.Max(1, oldAttacksPerRound);

But if APR was for example increased by 2, this is no longer correct.

The key here is that the formula for APR is this (pseudo code):

APR = 1 + Level / AttacksPerRoundIncreaseLevels

This means:

AttacksPerRoundIncreaseLevels = Level / (APR - 1)

So the minus 1 comes from the APR formula and only by luck is oldAttacksPerRound equal to APR - 1.

I fixed it with the correct formula and it will be included in the next release.

Thanks again for reporting it and providing a fix. Your fix would work in all current cases but I want to be safe for the future, so I adjusted it slightly.