Cleans up some ramp code.

Author: MistakeNot4892

code/game/base_turf.dm

@@ -34,7 +34,7 @@
 
 // Returns the open turf of a Z-stack by finding the nearest non-open turf below.
 /proc/get_open_turf_type(var/turf/T)
-	if(!HasBelow(T.z))
+	if(!istype(T) || !HasBelow(T.z))
 		return
 	var/turf/below = T
 	while ((below = GetBelow(below)))

code/game/turfs/turf_ramps.dm

@@ -1,6 +1,6 @@
 /turf/proc/handle_ramp_dug_below(turf/wall/natural/ramp)
 	if(simulated && !is_open())
-		ChangeTurf(get_open_turf_type(z))
+		ChangeTurf(get_open_turf_type(src))
 		return TRUE
 	return FALSE
 

code/game/turfs/walls/wall_icon.dm

@@ -112,6 +112,7 @@
 	other_connections = dirs_to_corner_states(other_dirs)
 
 /turf/wall/proc/update_wall_icon()
+
 	var/material_icon_base = get_wall_icon()
 	var/base_color = get_base_color()
 

code/game/turfs/walls/wall_natural_icon.dm

@@ -52,7 +52,7 @@
 		var/turf/floor_data = floor_type
 		new_icon       = initial(floor_data.icon)
 		new_icon_state = initial(floor_data.icon_state)
-		new_color      = initial(floor_data.color)
+		new_color      = base_color
 
 		var/turf/wall/natural/neighbor = get_step(src, turn(ramp_slope_direction, -90))
 		var/has_left_neighbor  = istype(neighbor) && neighbor.ramp_slope_direction == ramp_slope_direction
@@ -65,10 +65,10 @@
 			state = "ramp-blend-left"
 		else if(has_right_neighbor)
 			state = "ramp-blend-right"
-		var/image/I = image(material_icon_base, state, dir = ramp_slope_direction)
+		var/image/I = image(icon = material_icon_base, icon_state = state, dir = ramp_slope_direction)
 		add_overlay(I)
 		if(shine)
-			I = image(material_icon_base, "[state]-shine", dir = ramp_slope_direction)
+			I = image(icon = material_icon_base, icon_state = "[state]-shine", dir = ramp_slope_direction)
 			I.appearance_flags |= RESET_ALPHA
 			I.alpha = shine
 			add_overlay(I)

code/game/turfs/walls/wall_natural_ramps.dm

@@ -4,40 +4,23 @@
 	QDEL_NULL_LIST(engravings)
 
 	var/old_ao = permit_ao
-	if(ramp_slope_direction)
-
-		user?.visible_message(SPAN_NOTICE("\The [user] digs out \the [src], forming a ramp."))
-
-		drop_ore()
-		permit_ao  = FALSE
-		blocks_air = FALSE
-		density    = FALSE
-		opacity    = FALSE
-
-		// Pretend to be a normal floor turf under the ramp.
-		var/turf/under = floor_type
-		icon             = initial(under.icon)
-		icon_state       = initial(under.icon_state)
-		color            = initial(under.color)
-
-		decals = null
-		var/turf/ramp_above = GetAbove(src)
-		if(ramp_above)
-			ramp_above.handle_ramp_dug_below(src)
-		update_neighboring_ramps()
-
-	else
-
+	if(!ramp_slope_direction)
 		user?.visible_message(SPAN_NOTICE("\The [user] clears out \the [src]."))
-
-		permit_ao  = initial(permit_ao)
-		blocks_air = initial(blocks_air)
-		density    = initial(density)
-		color      = initial(color)
-		refresh_opacity()
-
-		icon = 'icons/turf/walls/natural.dmi'
-		icon_state = "blank"
+		ChangeTurf(floor_type)
+		return
+
+	user?.visible_message(SPAN_NOTICE("\The [user] digs out \the [src], forming a ramp."))
+	drop_ore()
+	permit_ao  = FALSE
+	blocks_air = FALSE
+	density    = FALSE
+	opacity    = FALSE
+	decals = null
+	var/turf/ramp_above = GetAbove(src)
+	if(ramp_above)
+		ramp_above.handle_ramp_dug_below(src)
+	update_neighboring_ramps()
+	update_icon()
 
 	if(!skip_icon_update)
 		for(var/turf/wall/natural/neighbor in RANGE_TURFS(src, 1))

code/modules/materials/definitions/solids/materials_solid_stone.dm

@@ -30,7 +30,7 @@
 /decl/material/solid/stone/Initialize()
 	. = ..()
 	texture = image('icons/turf/wall_texture.dmi', "concrete")
-	texture.appearance_flags |= RESET_COLOR
+	texture.appearance_flags |= RESET_COLOR | RESET_ALPHA
 	texture.blend_mode = BLEND_MULTIPLY
 
 /decl/material/solid/stone/get_wall_texture()