fix: b8 broken api endpoints and logging (AscensionGameDev#2126)

* Fix metrics endpoint from sending the jsob of a http response message instead of actual metric data.

* Fix logging db records not saving.

Not sure why this worked back in .net 4 and not now but we need to explicitly call .SaveChanges on the logging context

Author: jcsnider

Intersect.Server.Core/Database/Logging/Entities/ChatHistory.cs

@@ -68,8 +68,11 @@ public static void LogMessage(Player player, string message, ChatMessageType typ
 
         private static void Log(ChatHistory chatHistory)
         {
-            using var loggingContext = DbInterface.CreateLoggingContext(readOnly: false);
-            _ = loggingContext.ChatHistory.Add(chatHistory);
+            using (var loggingContext = DbInterface.CreateLoggingContext(readOnly: false))
+            {
+                loggingContext.ChatHistory.Add(chatHistory);
+                loggingContext.SaveChanges();
+            }
         }
     }
 }

Intersect.Server.Core/Database/Logging/Entities/GuildHistory.cs

@@ -104,8 +104,11 @@ public static void LogActivity(Guid guildId, Guid userId, Guid playerId, string
 
         private static void Log(GuildHistory guildHistory)
         {
-            using var loggingContext = DbInterface.CreateLoggingContext(readOnly: false);
-            _ = loggingContext.GuildHistory.Add(guildHistory);
+            using (var loggingContext = DbInterface.CreateLoggingContext(readOnly: false))
+            {
+                loggingContext.GuildHistory.Add(guildHistory);
+                loggingContext.SaveChanges();
+            }
         }
     }
 }

Intersect.Server.Core/Database/Logging/Entities/TradeHistory.cs

@@ -99,8 +99,11 @@ public static void LogTrade(Guid tradeId, Player player, Player target, Item[] o
 
         private static void Log(TradeHistory tradeHistory)
         {
-            using var loggingContext = DbInterface.CreateLoggingContext(readOnly: false);
-            _ = loggingContext.TradeHistory.Add(tradeHistory);
+            using (var loggingContext = DbInterface.CreateLoggingContext(readOnly: false))
+            {
+                loggingContext.TradeHistory.Add(tradeHistory);
+                loggingContext.SaveChanges();
+            }
         }
     }
 }

Intersect.Server.Core/Database/Logging/Entities/UserActivityHistory.cs

@@ -129,8 +129,11 @@ public static void LogActivity(Guid userId, Guid playerId, string ip, PeerType p
 
         private static void Log(UserActivityHistory userActivityHistory)
         {
-            using var loggingContext = DbInterface.CreateLoggingContext(readOnly: false);
-            _ = loggingContext.UserActivityHistory.Add(userActivityHistory);
+            using (var loggingContext = DbInterface.CreateLoggingContext(readOnly: false))
+            {
+                loggingContext.UserActivityHistory.Add(userActivityHistory);
+                loggingContext.SaveChanges();
+            }
         }
     }
 }

Intersect.Server/Web/RestApi/Routes/V1/InfoController.cs

@@ -56,12 +56,10 @@ public object Stats()
         }
 
         [HttpGet("metrics")]
+        [Produces("application/json")]
         public object StatsMetrics()
         {
-            return new HttpResponseMessage()
-            {
-                Content = new StringContent(MetricsRoot.Instance.Metrics, System.Text.Encoding.UTF8, "application/json")
-            };
+            return Ok(MetricsRoot.Instance.Metrics );
         }
     }
 }