fix: unequip equipment when depositing into the bank (AscensionGameDev#2157)

Author: Arufonsu

Intersect.Server.Core/Entities/BankInterface.cs

@@ -236,6 +236,13 @@ out var slotIndicesToRemoveFrom
                     Debug.Assert(slotToRemoveFrom != default);
                     var quantityToRemoveFromSlot = Math.Min(remainingQuantityToRemove, slotToRemoveFrom.Quantity);
                     slotToRemoveFrom.Quantity -= quantityToRemoveFromSlot;
+
+                    // If the item is equipped equipment, we need to unequip it before taking it out of the inventory.
+                    if (itemDescriptor.ItemType == ItemType.Equipment && slotIndexToRemoveFrom > -1)
+                    {
+                        mPlayer.EquipmentProcessItemLoss(slotIndexToRemoveFrom);
+                    }
+
                     if (slotToRemoveFrom.Quantity < 1)
                     {
                         slotToRemoveFrom.Set(Item.None);
@@ -264,14 +271,6 @@ out var slotIndicesToRemoveFrom
                     Log.Error($"{mPlayer.Id} did not have {remainingQuantity}x {itemDescriptor.Id} taken");
                 }
 
-                if (itemDescriptor.ItemType == ItemType.Equipment)
-                {
-                    if (inventorySlotIndex > -1)
-                    {
-                        mPlayer.EquipmentProcessItemLoss(inventorySlotIndex);
-                    }
-                }
-
                 if (sendUpdate)
                 {
                     foreach (var slotIndexToUpdate in slotIndicesToRemoveFrom)