Fix lint errors and refactor types

Author: Pytal

src/helpers/format.ts

@@ -1,4 +1,4 @@
-export const formatStdout = (stdout: string) =>
+export const formatStdout = (stdout: string): string =>
   stdout
     .replace(/.*\n/, '')
     .replace(/- Removing|- Saving|- Retrieving project…/, '')

src/helpers/helpers.ts

@@ -3,13 +3,13 @@ import { exec as execCallback } from 'child_process'
 import pLimit = require('p-limit')
 const { access } = fs
 
-export const exists = (path: string) =>
+export const exists = (path: string): Promise<boolean> =>
   access(path)
     .then(_ => true)
     .catch(_ => false)
 
 export const exec = (cmd: string): Promise<string> =>
-  new Promise((res, rej) =>
+  new Promise((res, _rej) =>
     execCallback(cmd, (_, stdout, stderr) => res(stdout + stderr)),
   )
 

src/helpers/parse.ts

@@ -1,12 +1,20 @@
-import type { Argv } from '../types/types'
+import type { DeploymentEnv } from '../types/shared'
 
-export const parseArgv = (argv: typeof process.argv) => {
+export const parseArgv = (
+  argv: typeof process.argv,
+): {
+  deploymentEnv: DeploymentEnv
+  varNameArr: string[] | null
+} => {
   if (
     argv[2] === 'production' ||
     argv[2] === 'preview' ||
     argv[2] === 'development'
   ) {
-    const [deploymentEnv, ...varNameArr]: Argv = [argv[2], ...argv.slice(3)]
+    const [deploymentEnv, ...varNameArr]: [DeploymentEnv, ...string[]] = [
+      argv[2],
+      ...argv.slice(3),
+    ]
 
     return { deploymentEnv, varNameArr: varNameArr.length ? varNameArr : null }
   } else {

src/helpers/print.ts

@@ -1,3 +1,4 @@
 import { formatStdout } from './format'
 
-export const printStdout = (stdout: string) => console.log(formatStdout(stdout))
+export const printStdout = (stdout: string): void =>
+  console.log(formatStdout(stdout))

src/types/types.ts src/types/shared.tssrc/types/types.ts renamed to src/types/shared.ts

@@ -1,3 +1,2 @@
 export type DeploymentEnv = 'production' | 'preview' | 'development'
-export type Argv = [DeploymentEnv, ...string[]]
 export type EnvMap = Record<string, string>

src/utils/get-env.ts

@@ -1,11 +1,11 @@
 import { exists } from '../helpers/helpers'
 import { GetEnvVars } from 'env-cmd'
-import type { DeploymentEnv, EnvMap } from '../types/types'
+import type { DeploymentEnv, EnvMap } from '../types/shared'
 
 export const getEnvMap = async (
   deploymentEnv: DeploymentEnv,
   varNameArr?: string[],
-) => {
+): Promise<EnvMap> => {
   let envMap: EnvMap
 
   if (await exists(`.env.${deploymentEnv}`)) {

src/utils/vercel-env.ts

@@ -1,7 +1,7 @@
 import { exec, limit } from '../helpers/helpers'
 import { printStdout } from '../helpers/print'
 import { getEnvMap } from './get-env'
-import type { DeploymentEnv, EnvMap } from '../types/types'
+import type { DeploymentEnv, EnvMap } from '../types/shared'
 
 const removeEnv = async (deploymentEnv: DeploymentEnv, envMap: EnvMap) => {
   const stdoutArr: Promise<void>[] = []
@@ -38,7 +38,7 @@ const addEnv = async (deploymentEnv: DeploymentEnv, envMap: EnvMap) => {
 export const deployEnv = async (
   deploymentEnv: DeploymentEnv,
   varNameArr?: string[],
-) => {
+): Promise<void> => {
   const envMap = await getEnvMap(deploymentEnv, varNameArr)
 
   await removeEnv(deploymentEnv, envMap)