Refactor

Author: Pytal

src/cli.ts

@@ -1,6 +1,6 @@
 import { parseArgv } from './helpers/parse'
 import { deployEnv } from './utils/vercel-env'
 
-const { deploymentEnv, varNameList } = parseArgv(process.argv)
-if (!varNameList) deployEnv(deploymentEnv)
-else deployEnv(deploymentEnv, varNameList)
+const { deploymentEnv, varNameArr } = parseArgv(process.argv)
+if (!varNameArr) deployEnv(deploymentEnv)
+else deployEnv(deploymentEnv, varNameArr)

src/helpers/parse.ts

@@ -6,9 +6,9 @@ export const parseArgv = (argv: typeof process.argv) => {
     argv[2] === 'preview' ||
     argv[2] === 'development'
   ) {
-    const [deploymentEnv,...varNameList]: Argv = [argv[2],...argv.slice(3)]
+    const [deploymentEnv,...varNameArr]: Argv = [argv[2],...argv.slice(3)]
 
-    return { deploymentEnv, varNameList: varNameList.length ? varNameList : null }
+    return { deploymentEnv, varNameArr: varNameArr.length ? varNameArr : null }
   }
   else {
     console.log( 'Usage: deploy-env [production | preview | development] [ENV_VAR]...' )

src/types/types.ts

@@ -1,3 +1,3 @@
 export type DeploymentEnv = 'production' | 'preview' | 'development'
 export type Argv = [DeploymentEnv,...string[]]
-export type EnvVarMap = Record<string, string>
+export type EnvMap = Record<string, string>

src/utils/get-env.ts

@@ -1,25 +1,25 @@
 import { exists } from '../helpers/helpers'
 import { GetEnvVars } from 'env-cmd'
-import type { DeploymentEnv, EnvVarMap } from '../types/types'
+import type { DeploymentEnv, EnvMap } from '../types/types'
 
-export const getEnvVarMap = async (deploymentEnv: DeploymentEnv, varNameList?: string[]) => {
-  let envVarMap: EnvVarMap
+export const getEnvMap = async (deploymentEnv: DeploymentEnv, varNameArr?: string[]) => {
+  let envMap: EnvMap
 
   if (await exists(`.env.${deploymentEnv}`)) {
-    envVarMap = await GetEnvVars({ envFile: { filePath: `.env.${deploymentEnv}` } })
+    envMap = await GetEnvVars({ envFile: { filePath: `.env.${deploymentEnv}` } })
   }
   else if (await exists('.env')) {
-    envVarMap = await GetEnvVars({ envFile: { filePath: '.env' } })
+    envMap = await GetEnvVars({ envFile: { filePath: '.env' } })
   }
   else {
-    envVarMap = await GetEnvVars({ rc: { environments: [deploymentEnv] } })
+    envMap = await GetEnvVars({ rc: { environments: [deploymentEnv] } })
   }
 
-  if (varNameList) {
-    const filteredEnvVarMap: EnvVarMap = {}
-    for (const varName of varNameList) filteredEnvVarMap[varName] = envVarMap[varName]
-    return filteredEnvVarMap
+  if (varNameArr) {
+    const filteredEnvMap: EnvMap = {}
+    for (const varName of varNameArr) filteredEnvMap[varName] = envMap[varName]
+    return filteredEnvMap
   }
 
-  return envVarMap
+  return envMap
 }

src/utils/vercel-env.ts

@@ -1,38 +1,39 @@
 import { exec, limit } from '../helpers/helpers'
 import { printStdout } from '../helpers/print'
-import { getEnvVarMap } from './get-env'
-import type { DeploymentEnv, EnvVarMap } from '../types/types'
+import { getEnvMap } from './get-env'
+import type { DeploymentEnv, EnvMap } from '../types/types'
 
-const removeEnv = async (deploymentEnv: DeploymentEnv, envVarMap: EnvVarMap) => {
-  const stdoutList: Promise<void>[] = []
-  for (const varName in envVarMap) {
-    stdoutList.push(
+const removeEnv = async (deploymentEnv: DeploymentEnv, envMap: EnvMap) => {
+  const stdoutArr: Promise<void>[] = []
+
+  for (const varName in envMap) {
+    stdoutArr.push(
       limit(() => exec( `vercel env rm ${varName} ${deploymentEnv} -y` ).then(printStdout))
     )
   }
 
-  await Promise.all(stdoutList)
+  await Promise.all(stdoutArr)
 }
 
-const addEnv = async (deploymentEnv: DeploymentEnv, envVarMap: EnvVarMap) => {
+const addEnv = async (deploymentEnv: DeploymentEnv, envMap: EnvMap) => {
   // new syntax: https://github.com/vercel/vercel/pull/5413 released in v21 https://github.com/vercel/vercel/releases/tag/vercel%4021.0.0
   // ref: https://github.com/vercel/vercel/blob/vercel%4021.0.0/packages/now-cli/src/types.ts#L206
   const varType = 'secret'
-  const stdoutList: Promise<void>[] = []
+  const stdoutArr: Promise<void>[] = []
 
-  for (const varName in envVarMap) {
-    const varValue = envVarMap[varName]
-    stdoutList.push(
+  for (const varName in envMap) {
+    const varValue = envMap[varName]
+    stdoutArr.push(
       limit(() => exec( `printf %s "${varValue}" | vercel env add ${varType} ${varName} ${deploymentEnv}` ).then(printStdout))
     )
   }
 
-  await Promise.all(stdoutList)
+  await Promise.all(stdoutArr)
 }
 
-export const deployEnv = async (deploymentEnv: DeploymentEnv, varNameList?: string[]) => {
-  const envVarMap = await getEnvVarMap(deploymentEnv, varNameList)
+export const deployEnv = async (deploymentEnv: DeploymentEnv, varNameArr?: string[]) => {
+  const envMap = await getEnvMap(deploymentEnv, varNameArr)
 
-  await removeEnv(deploymentEnv, envVarMap)
-  await addEnv(deploymentEnv, envVarMap)
+  await removeEnv(deploymentEnv, envMap)
+  await addEnv(deploymentEnv, envMap)
 }