Update environment configuration and improve admin user handling in routes

Author: Gildofj

.env.example

@@ -1,4 +1,5 @@
 PYTHONPATH=/server
+BASE_URL=http://localhost:8000
 
 # SQLite Database Configuration
 SQLITE_PATH=/app/data/pynewsdb.db

app/routers/admin/routes.py

@@ -16,15 +16,15 @@
 
 
 async def create_admin(session: AsyncSession):
-    ADMIN_USER = os.getenv("ADMIN_USER")
-    ADMIN_PASSWORD = os.getenv("ADMIN_PASSWORD")
-    ADMIN_EMAIL = os.getenv("ADMIN_EMAIL")
+    ADMIN_USER = os.getenv("ADMIN_USER", "")
+    ADMIN_PASSWORD = os.getenv("ADMIN_PASSWORD", "")
+    ADMIN_EMAIL = os.getenv("ADMIN_EMAIL", "")
     password = ADMIN_PASSWORD
     hashed_password = auth.hash_password(password)
     community = DBCommunity(
         username=ADMIN_USER,
         email=ADMIN_EMAIL,
-        password=hashed_password,
+        password=str(hashed_password),
         role="admin",
     )
     await create_community(session=session, community=community)

docker-compose.yaml

@@ -1,5 +1,3 @@
-version: "3.8"
-
 services:
   pynews-api:
     build:
@@ -42,22 +40,14 @@ services:
       "
     restart: "no"
 
-volumes:
-  sqlite_data:
-    driver: local
-    driver_opts:
-      type: none
-      o: bind
-      device: ./data
-
   scanapi-tests:
     build:
       context: .
       dockerfile: Dockerfile
       target: scanapi-test
     container_name: scanapi-tests
     env_file:
-      - .env.test
+      - .env
     environment:
       - BASE_URL=http://pynews-server:8000
     volumes:
@@ -79,6 +69,12 @@ volumes:
 
 volumes:
   report-data:
+  sqlite_data:
+    driver: local
+    driver_opts:
+      type: none
+      o: bind
+      device: ./data
 
 networks:
   default:

scanapi/scanapi.yaml

@@ -2,31 +2,26 @@ endpoints:
   - name: py_news_server
     path: ${BASE_URL}/api
     vars:
-      community_username: ${USERNAME_TEST}
-      community_password: ${PASSWORD_TEST}
+      admin_user: ${ADMIN_USER}
+      admin_password: ${ADMIN_PASSWORD}
     requests:
       - name: healthcheck
         path: healthcheck
         tests:
           - !include tests/status_code_is_200.yaml
           - !include tests/healthcheck/body_status_healthy.yaml
-      - name: create_community
-        path: authentication/create_community
-        method: POST
-        body:
-          name: "Test Community"
       - name: login_for_access_token
         path: authentication/token
         method: POST
         headers:
           Content-Type: application/x-www-form-urlencoded
         body:
-          username: ${community_username}
-          password: ${community_password}
+          username: ${admin_user}
+          password: ${admin_password}
         tests:
           - !include tests/status_code_is_200.yaml
         vars:
-          access_token: ${{ response.json()["access_token"] }}
+          access_token: ${{ response.json()["access_token"] if response.status_code == 200 else "" }}
     endpoints:
       - !include libraries_authenticated.yaml
       - !include libraries_unauthenticated.yaml