Some minor changes + added normalization for Config

Author: PythonHacker24

cmd/laclm/main.go

@@ -29,6 +29,7 @@ func exec() error {
 	/* exec() wraps run() protecting it with user interrupts  */
 
 	utils.InitLogger(true)
+
 	/* zap.L() can be used all over the code for global level logging */
 
 	zap.L().Info("Logger Initiated ...")

config.yaml

@@ -20,23 +20,23 @@ database:
 
 # logging configurations
 logging:
-  file:
-  max_size:
-  max_backups:
-  max_age:
-  compress:
+  file: "logs/app.log"
+  max_size: 100
+  max_backups: 5
+  max_age: 30
+  compress: true
 
 # filesystem server that needs management
 filesystem_servers:
-  - path:
-    method:
+  - path: /mnt/beegfs-1
+    method: "remote"
     remote:
-      host:
-      port:
+      host: "127.0.0.1"
+      port: 4444
 
 # authentication information
 authentication:
   ldap:
 
 backend_security:
-  jwt_expiry:
+  jwt_expiry: 1

config/loader.go

@@ -7,6 +7,12 @@ import (
 	"gopkg.in/yaml.v3"
 )
 
+/*
+	we need config normalization as well
+	config normalization fixes all the fields that are not present in config file 
+	and sets it to default value
+*/
+
 /* loads yaml config file from given file path */
 func LoadConfig(path string) {
 
@@ -25,6 +31,8 @@ func LoadConfig(path string) {
 			zap.Error(err),
 		)
     }
+
+	BackendConfig.Normalize()
 }
 
 /* loads environment variables */

internal/authentication/authentication.go

@@ -13,6 +13,8 @@ import (
 /* generating jwt token for user identification with specified configs */
 func GenerateJWT(username string) (string, error) {
 	expiryHours := config.BackendConfig.BackendSecurity.JWTExpiry
+
+	/* GET THIS INTO CONFIG SANITISATION */
 	if expiryHours == 0 {
 		expiryHours = 24
 	}

internal/models/models.go

@@ -10,7 +10,7 @@ type App struct {
 /* server deployment parameters */
 type Server struct {
 	Host string `yaml:"host"`
-	Port string `yaml:"port"`
+	Port int    `yaml:"port"`
 }
 
 /* database parameters */
@@ -31,12 +31,12 @@ type Logging struct {
 	MaxSize    int    `yaml:"max_size"`
 	MaxBackups int    `yaml:"max_backups"`
 	MaxAge     int    `yaml:"max_age"`
-	Compress   int    `yaml:"compress"`
+	Compress   bool   `yaml:"compress"`
 }
 
 /* file system server parameters */
 type FileSystemServers struct {
-	Remote *Remote `yaml:"remote"`
+	Remote *Remote `yaml:"remote,omitempty"`
 	Path   string  `yaml:"path"`
 	Method string  `yaml:"method"`
 }

internal/models/normalize.go

@@ -0,0 +1,11 @@
+package models
+
+func (m *Config) Normalize() {
+	if m.Server.Host == "" {
+		m.Server.Host = "localhost" 
+	}
+
+	if m.Server.Port == 0 {
+		m.Server.Port = 8080
+	}
+}

internal/utils/utils.go

@@ -4,6 +4,7 @@ import (
 	"log"
 	"os"
 
+	"github.com/PythonHacker24/linux-acl-management-backend/config"
 	"github.com/google/uuid"
 	"go.uber.org/zap"
 	"go.uber.org/zap/zapcore"
@@ -25,11 +26,11 @@ func InitLogger(isProduction bool) {
 		encoder = zapcore.NewJSONEncoder(zap.NewProductionEncoderConfig())
 		logLevel = zapcore.InfoLevel
 		writeSyncer = zapcore.AddSync(&lumberjack.Logger{
-			Filename:   "logs/app.log",
-			MaxSize:    100, // MB
-			MaxBackups: 5,
-			MaxAge:     30, // days
-			Compress:   true,
+			Filename:   config.BackendConfig.Logging.File,
+			MaxSize:    config.BackendConfig.Logging.MaxSize, // MB
+			MaxBackups: config.BackendConfig.Logging.MaxBackups, 
+			MaxAge:     config.BackendConfig.Logging.MaxBackups, // days
+			Compress:   config.BackendConfig.Logging.Compress,
 		})
 	} else {