fix the types

Author: AbstractUmbra

.github/workflows/coverage_and_lint.yml

@@ -58,7 +58,7 @@ jobs:
         if: ${{ steps.cached-pip-wheels.outputs.cache-hit != 'true' }}
         id: install-deps
         run: |
-          poetry install --without=dev --no-interaction
+          poetry install --no-interaction
 
       - name: Activate venv @ ${{ matrix.python-version }}
         run: |

core/checks.py

@@ -20,14 +20,22 @@
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
 """
+from __future__ import annotations
+
+from typing import TYPE_CHECKING, Any
+
 from discord.ext import commands
 
 import constants
-import core
+from core.context import GuildContext
+
+
+if TYPE_CHECKING:
+    from discord.ext.commands._types import Check  # type: ignore # why would this need stubs
 
 
-def is_role_or_higher(role_id: int):
-    def predicate(ctx: core.Context):
+def is_role_or_higher(role_id: int) -> Check[Any]:
+    def predicate(ctx: GuildContext) -> bool:
         role = ctx.guild.get_role(role_id)
 
         # This should never be a problem, but just in case...
@@ -36,18 +44,12 @@ def predicate(ctx: core.Context):
             raise commands.CheckFailure(f"Role with ID <{role_id}> does not exist.")
 
         ignored = (constants.Roles.NITRO_BOOSTER, constants.Roles.MUTED)
-        roles = [
-            r
-            for r in ctx.author.roles
-            if r.id not in ignored and ctx.author.top_role >= r
-        ]
+        roles = [r for r in ctx.author.roles if r.id not in ignored and ctx.author.top_role >= r]
 
         if roles:
             return True
 
         # TODO: Change this to a custom exception.
-        raise commands.CheckFailure(
-            f"{ctx.author} is not in or higher than role <{role.name}(ID: {role.id})>."
-        )
+        raise commands.CheckFailure(f"{ctx.author} is not in or higher than role <{role.name}(ID: {role.id})>.")
 
     return commands.check(predicate)

core/context.py

@@ -11,6 +11,7 @@
 
 __all__ = (
     "Context",
+    "GuildContext",
     "Interaction",
 )
 
@@ -19,3 +20,8 @@
 
 class Context(commands.Context["Bot"]):
     pass
+
+
+class GuildContext(Context):
+    guild: discord.Guild  # type: ignore # type lie due to narrowing
+    author: discord.Member  # type: ignore # type lie due to narrowing

core/utils/paginator.py

@@ -32,6 +32,7 @@
 
 from core.context import Context
 
+
 if TYPE_CHECKING:
     from typing_extensions import Self
 

pyproject.toml

@@ -33,6 +33,7 @@ combine_star = true
 
 
 [tool.pyright]
+ignore = ["core/utils/paginator.py", "constants/_meta.py"] # TODO: Undo this when someone fixes the module lol
 useLibraryCodeForTypes = true
 typeCheckingMode = "strict"
 pythonVersion = "3.11"