Change retain_cache default value to True

Change retain_cache default value to True to mimic behaviour before part_channels implementation.

Author: chillymosh

docs/changelog.rst

@@ -8,13 +8,14 @@ Massive documentation updates
     - Removed unexpected loop termination from `WSConnection._close()`
     - Fix bug where # prefixed channel names and capitals in initial_channels would not trigger :func:`twitchio.Client.event_ready`
     - Adjusted join channel rate limit handling
-    - Added `retain_cache` kwarg to Client and Bot
+    - Added `retain_cache` kwarg to Client and Bot. Default is True.
     - :func:`User.create_clip` has been fixed by converting bool to string in http request
     - Poll endpoints added :func:`User.fetch_polls` :func:`User.create_poll` and :func:`User.end_poll`
     - :func:`Client.fetch_cheermotes` color attribute corrected
     - :func:`User.fetch_channel_teams` returns empty list if no teams found rather than unhandled error
-    - :func:`User.fetch_goals` method added
-    - :func:`User.fetch_chat_settings` and :func:`User.update_chat_settings` methods added
+    - Added :func:`User.fetch_goals` method
+    - Added :func:`User.fetch_chat_settings` and :func:`User.update_chat_settings` methods
+    - Added :func:`Client.part_channels` method
 
 - ext.commands
     - :func:`Bot.handle_commands` now also invokes on threads / replies

twitchio/client.py

@@ -62,7 +62,7 @@ class Client:
         An optional float in seconds to send a PING message to the server. Defaults to 30.0.
     retain_cache: Optional[bool]
         An optional bool that will retain the cache if PART is received from websocket when True.
-        It will still remove from cache if part_channels is manually called. Defaults to False.
+        It will still remove from cache if part_channels is manually called. Defaults to True.
 
     Attributes
     ------------
@@ -78,7 +78,7 @@ def __init__(
         initial_channels: Union[list, tuple, Callable] = None,
         loop: asyncio.AbstractEventLoop = None,
         heartbeat: Optional[float] = 30.0,
-        retain_cache: Optional[bool] = False,
+        retain_cache: Optional[bool] = True,
     ):
 
         self.loop: asyncio.AbstractEventLoop = loop or asyncio.get_event_loop()

twitchio/ext/commands/bot.py

@@ -55,7 +55,7 @@ def __init__(
         client_secret: str = None,
         initial_channels: Union[list, tuple, Callable] = None,
         heartbeat: Optional[float] = 30.0,
-        retain_cache: Optional[bool] = False,
+        retain_cache: Optional[bool] = True,
         **kwargs,
     ):
         super().__init__(

twitchio/websocket.py

@@ -60,7 +60,7 @@ def __init__(
         token: str = None,
         modes: tuple = None,
         initial_channels: List[str] = None,
-        retain_cache: Optional[bool] = False,
+        retain_cache: Optional[bool] = True,
     ):
         self._loop = loop
         self._backoff = ExponentialBackoff()