Remove duplicate fetch_channel and fix Chatter badges (#200)

* Removed duplicate fetch_channel
Updated docstring fetch_channel

* Changed badges to a property
returns a dict

* change to more obvious wording

* fetch duplicate fetch_channel
update docstring

* added founder to is_subscriber

Author: chillymosh

twitchio/chatter.py

@@ -105,11 +105,11 @@ class Chatter(PartialChatter):
     def __init__(self, websocket: "WSConnection", **kwargs):
         super(Chatter, self).__init__(websocket, **kwargs)
         self._tags = kwargs.get("tags", None)
-        self._badges = kwargs.get("badges", {})
         self._ws = websocket
 
         if not self._tags:
             self.id = None
+            self._badges = None
             self._turbo = None
             self._sub = None
             self._mod = None
@@ -118,6 +118,7 @@ def __init__(self, websocket: "WSConnection", **kwargs):
             return
 
         self.id = self._tags.get("user-id")
+        self._badges = self._tags.get("badges")
         self._turbo = self._tags.get("turbo")
         self._sub = self._tags["subscriber"]
         self._mod = int(self._tags["mod"])
@@ -140,6 +141,11 @@ def name(self) -> str:
         """The users name. This may be formatted differently than display name."""
         return self._name or (self.display_name and self.display_name.lower())
 
+    @property
+    def badges(self) -> dict:
+        """The users name. This may be formatted differently than display name."""
+        return {k: v for k, v in [badge.split("/") for badge in self._badges.split(",")]}
+
     @property
     def display_name(self) -> str:
         """The users display name."""
@@ -176,7 +182,7 @@ def is_subscriber(self) -> Optional[bool]:
 
         Could be None if no Tags were received.
         """
-        return self._sub
+        return self._sub or 'founder' in self._tags
 
     @property
     def prediction(self) -> Optional[PredictionEnum]:

twitchio/client.py

@@ -302,25 +302,6 @@ def get_channel(self, name: str) -> Optional[Channel]:
 
             return Channel(name=name, websocket=self._connection)
 
-    async def fetch_channel(self, broadcaster: str) -> list:
-        """Retrieve a channel from the API.
-
-        Parameters
-        -----------
-        name: str
-            The channel name or ID to request from API. Returns empty list if no channel was found.
-
-        Returns
-        --------
-            :class:`list`
-        """
-
-        if not broadcaster.isdigit():
-            get_id = await self.fetch_users(names=[broadcaster.lower()])
-            broadcaster = get_id[0].id
-
-        return await self._http.get_channels(broadcaster)
-
     async def join_channels(self, channels: Union[List[str], Tuple[str]]):
         """|coro|
 
@@ -420,7 +401,7 @@ async def fetch_channel(self, broadcaster: str):
 
         Parameters
         -----------
-        name: str
+        broadcaster: str
             The channel name or ID to request from API. Returns empty dict if no channel was found.
 
         Returns