Merge pull request #164 from Q42/Template.Android-161-99-merge

Cleanup github actions

Author: ninovanhooff

.github/workflows/_prepare-all.yml

@@ -45,7 +45,7 @@ jobs:
           app: ${{ secrets.FIREBASE_PROD_APP_ID }}
           credentials: ${{ secrets.FIREBASE_CREDENTIALS }}
           # groups: "beta-testers" // add this line if you want to specify a group of testers which will be invited to test this build. Make sure to create the group in Firebase Console first.
-          releaseNotes: Release build for ${{ github.ref_name }} branch - Run ${{ github.run_number }} - ${{ github.sha }}
+          release-notes: Release build for ${{ github.ref_name }} branch - Run ${{ github.run_number }} - ${{ github.sha }}
 
       - name: Build Prod Release Bundle
         run: ./gradlew bundleProdRelease --stacktrace

.github/workflows/_prepare-release.yml

@@ -119,9 +119,9 @@ To change this to your own firebase project, you need to set two secrets:
 - `FIREBASE_CREDENTIALS` from your firebase project. More info how to obtain it can be found
   in [creating a service account](https://github.com/nickwph/firebase-app-distribution-action?tab=readme-ov-file#download-credentials-from-firebase).
 
-With the default configuration, all commits on develop will be pushed to Firebase App Distribution
-and users in the test group "beta-testers" will receive an email with a link to download the
-app.
+With the default configuration, all commits on develop will be pushed to Firebase App Distribution.
+To also make these available to a test group, you can enable the `groups` parameter in the
+[firebase yml](.github/workflows/firebase-app-distribution.yml) file.
 
 #### Self-hosted runner
 

.github/workflows/firebase-app-distribution.yml

@@ -94,3 +94,23 @@ dependencies {
     api platform(libs.firebaseBoM)
     implementation(libs.firebaseCrashlytics)
 }
+
+tasks.register("checkSigningConfig") {
+    doFirst {
+        def cfg = android.signingConfigs.upload
+        if(!cfg.storeFile?.exists()) {
+            throw new GradleException("Keystore file for Signing config 'upload' is not found.")
+        }
+        else if (
+                !cfg.storePassword ||
+                !cfg.keyAlias ||
+                !cfg.keyPassword) {
+            throw new GradleException("Signing config 'upload' is missing values for release build.")
+        }
+    }
+}
+
+// Attach checkSigningConfig to all release variant preBuild tasks
+tasks.matching { it.name =~ /assemble.*Release/ }.configureEach { task ->
+    task.dependsOn("checkSigningConfig")
+}