Derive Copy, Clone, Debug, Eq, PartialEq for EncryptedNote instead of explicit imlps as const generic are stabilized

Author: dmidem

zebra-chain/src/orchard/note/ciphertexts.rs

@@ -9,30 +9,9 @@ use crate::serialization::{SerializationError, ZcashDeserialize, ZcashSerialize}
 /// A ciphertext component for encrypted output notes.
 ///
 /// Corresponds to the Orchard 'encCiphertext's
-#[derive(Deserialize, Serialize)]
+#[derive(Deserialize, Serialize, Copy, Clone, Debug, Eq, PartialEq)]
 pub struct EncryptedNote<const N: usize>(#[serde(with = "BigArray")] pub(crate) [u8; N]);
 
-// These impls all only exist because of array length restrictions.
-// TODO: use const generics https://github.com/ZcashFoundation/zebra/issues/2042
-
-impl<const N: usize> Copy for EncryptedNote<N> {}
-
-impl<const N: usize> Clone for EncryptedNote<N> {
-    fn clone(&self) -> Self {
-        *self
-    }
-}
-
-impl<const N: usize> fmt::Debug for EncryptedNote<N> {
-    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
-        f.debug_tuple("EncryptedNote")
-            .field(&hex::encode(&self.0[..]))
-            .finish()
-    }
-}
-
-impl<const N: usize> Eq for EncryptedNote<N> {}
-
 impl<const N: usize> From<[u8; N]> for EncryptedNote<N> {
     fn from(bytes: [u8; N]) -> Self {
         EncryptedNote(bytes)
@@ -45,12 +24,6 @@ impl<const N: usize> From<EncryptedNote<N>> for [u8; N] {
     }
 }
 
-impl<const N: usize> PartialEq for EncryptedNote<N> {
-    fn eq(&self, other: &Self) -> bool {
-        self.0[..] == other.0[..]
-    }
-}
-
 impl<const N: usize> ZcashSerialize for EncryptedNote<N> {
     fn zcash_serialize<W: io::Write>(&self, mut writer: W) -> Result<(), io::Error> {
         writer.write_all(&self.0[..])?;