Clear ENABLE_ZSA in Flags arbitrary strategy to fix V5 transaction roundtrip test

Author: dmidem

zebra-chain/src/orchard/arbitrary.rs

@@ -126,7 +126,15 @@ impl Arbitrary for Flags {
     type Parameters = ();
 
     fn arbitrary_with(_args: Self::Parameters) -> Self::Strategy {
-        (any::<u8>()).prop_map(Self::from_bits_truncate).boxed()
+        (any::<u8>())
+            .prop_map(|byte| {
+                // Clear ENABLE_ZSA: it is only valid in V6, but this strategy
+                // is also used for V5 transactions where it causes a deserialization error.
+                #[cfg(feature = "tx_v6")]
+                let byte = byte & !(Flags::ENABLE_ZSA.bits());
+                Self::from_bits_truncate(byte)
+            })
+            .boxed()
     }
 
     type Strategy = BoxedStrategy<Self>;